feat(content): load example-apps via content-loader functionality #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move example-app definitions from `argocd/example-apps` and `applications/` into `examples/example-apps-via-content-loader` - Adjust Dockerfile to initialize example-apps folder as standalone git repo for content-loader - Update `GitopsPlaygroundCli` to include content examples via `--content.examples` flag - Extend config merging logic (`MapUtils.deepMerge`) to support additional example content source - Update schema, configurator, and tests to handle example-apps path and validation - Clean up redundant templates and adjust paths accordingly This refactor isolates example application definitions into a dedicated content-loader directory, simplifying configuration handling and enabling dynamic content loading via the CLI.
- extract hardcoded references for example-apps in unit test
mdroll
force-pushed
the
feature/extract-example-apps
branch
from
a26830b to
2be7e88
Compare
mdroll
changed the title
…back to main for test evaluation
mdroll
force-pushed
the
feature/extract-example-apps
branch
from
a3cbc49 to
a727683
Compare
…edentials verification parts
nihussmann
commented
Oct 30, 2025
| source: | ||
| path: argocd/ | ||
| repoURL: ${scmm.repoUrl}argocd/example-apps<#if config.scmm.provider == "gitlab">.git</#if> | ||
| repoURL: "http://scmm.${config.application.namePrefix}scm-manager.svc.cluster.local/scm/repo/${config.application.namePrefix}argocd/example-apps" |
There was a problem hiding this comment.
Example apps would only work with the SCM-Manager instance running internally on the same Kubernetes cluster. This setup would not support an external SCM-Manager.
nihussmann
commented
Oct 31, 2025
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: Application | ||
| metadata: | ||
| name: misc-example-apps-production |
There was a problem hiding this comment.
guess this will only work in non dedicated instances.
nihussmann
commented
Oct 31, 2025
| } | ||
| } | ||
|
|
||
| static class ImagesSchema { |
There was a problem hiding this comment.
Readme.md still lists this params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argocd/example-appsandapplications/intoexamples/example-apps-via-content-loaderGitopsPlaygroundClito include content examples via--content.examplesflagMapUtils.deepMerge) to support additional example content sourceThis refactor isolates example application definitions into a dedicated content-loader directory, simplifying configuration handling and enabling dynamic content loading via the CLI.