refactor(pluginpresets): dedicated pluginspec for PluginPreset #1528
+280
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core-apis
helm-charts
documentation
IvoGoman
force-pushed
the
refactor/split-preset-plugin-spec
branch
2 times, most recently
from
4cf5227 to
1ed39e6
Compare
IvoGoman
force-pushed
the
refactor/split-preset-plugin-spec
branch
from
00f917e to
aebced6
Compare
not all values of a PluginSpec may be set in a PluginPreset. this provides a copy of the PluginSpec for use in PluginPreset types. this avoids additional validation to ensure these values are not set or unexpected behaviour if they are ignored by the controller.
IvoGoman
force-pushed
the
refactor/split-preset-plugin-spec
branch
from
22ceca2 to
a433dc6
Compare
|
This PR is stale because it has been open for 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
not all values of a PluginSpec may be set in a PluginPreset. this provides a copy of the PluginSpec for use in PluginPreset types. this avoids additional validation to ensure these values are not set or unexpected behaviour if they are ignored by the controller.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist