generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(catalogs): implements catalog options override capability #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
needs #1597 to be merged for writing e2e |
1b264f6 to
6c607ab
Compare
IvoGoman
previously approved these changes
Nov 14, 2025
6c607ab to
6114371
Compare
Contributor
Author
|
needs cloudoperators/common#49 to fix the change in shared e2e workflow |
5680250 to
c63b20c
Compare
c63b20c to
2b0d6c7
Compare
IvoGoman
reviewed
Nov 25, 2025
a041cb2 to
6df99a4
Compare
IvoGoman
previously approved these changes
Nov 28, 2025
6df99a4 to
3d09a80
Compare
IvoGoman
previously approved these changes
Nov 28, 2025
when specified, catalog can prepare kustomize patches to override pluginDefinition option's default value matched by its name. Catalog controller also saves the archive of external artifact to a tmp location for repeated reconciliations and avoids fetches from source-watcher if the archive digest hasn't changed. Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): generate open api docs Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): tidy up! Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): add artifact fetch retries flag and remove ext artifact watch Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): propagate retries to artifactory Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): remove os read file helper Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): allow scenario to be initialized without a testData yaml Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): adds catalog options override e2e scenario. Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): local flux setup network policy This policy allows greenhouse controller manager to fetch artifacts from source-watcher Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): test e2e setup Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): use the fix from common e2e workflow Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): add pod selector to netpol Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): use new context for artifact fetcher with 15s timeout Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): flux netpol combine podSelector with namespaceSelector Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): apply review suggestions Co-authored-by: IvoGoman <ivo.gosemann@sap.com> (chore): re-use helper from test pkg Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): update readme Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): fix var name Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): fix fmt Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): force flux to reconcile faster in e2e Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): return err if option not found for overrides Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): extend manifest extraction with name filtering and local resource builder Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): use helm manifest pkg to extract (C)PD Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
3d09a80 to
35c6c74
Compare
IvoGoman
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when overrides for options are spec'd, Catalog controller can prepare
Kustomizepatches to overridePluginDefinitionoption's default value matched by its name.Catalog controller does this by extracting the archive of the
PluginDefinitionmanifests resolved by fluxGitRepositoryand resource composition fromArtifactGenerator. The archive URL is available in a referencing KindExternalArtifactwhich is fed as a source for fluxKustomization.Catalog controller also saves the archive of external artifact to a tmp location, to avoid archive fetches from source-watcher for repeated reconciliations and the digest hasn't changed.
Example
If an option is overridden, then the description of the option is modified to contain
(overridden by Catalog)at the end.What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist