Skip to content

Conversation

@mikolajkucinski
Copy link
Contributor

Description

Add RetriesExhausted condition to Plugin status to indicate when a HelmRelease has exhausted all install/upgrade retries. The condition message shows the current failure counts and max retries configured.

Set reconcile.fluxcd.io/resetAt annotation alongside requestedAt when the greenhouse.sap/reconcile annotation is used. This ensures Flux resets the failure counters, allowing the HelmRelease to retry after fixing the underlying issue.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@mikolajkucinski mikolajkucinski force-pushed the fix/plugin-stuck-if-retries-reached branch from f4330ee to 7c87398 Compare December 12, 2025 08:56
@mikolajkucinski mikolajkucinski marked this pull request as ready for review December 12, 2025 12:42
@mikolajkucinski mikolajkucinski requested a review from a team as a code owner December 12, 2025 12:42
@mikolajkucinski mikolajkucinski force-pushed the fix/plugin-stuck-if-retries-reached branch from 7c87398 to f0c3a6e Compare December 16, 2025 14:56
@mikolajkucinski mikolajkucinski force-pushed the fix/plugin-stuck-if-retries-reached branch 2 times, most recently from 73a9ec1 to af5411f Compare December 16, 2025 17:35
Add RetriesExhausted condition to Plugin status and set resetAt
annotation to allow retry reset via greenhouse.sap/reconcile.

On-behalf-of: @SAP mikolaj.kucinski@sap.com
@mikolajkucinski mikolajkucinski force-pushed the fix/plugin-stuck-if-retries-reached branch from af5411f to e9a9a0a Compare December 18, 2025 08:20
@mikolajkucinski mikolajkucinski merged commit 917488c into main Dec 18, 2025
26 of 28 checks passed
@mikolajkucinski mikolajkucinski deleted the fix/plugin-stuck-if-retries-reached branch December 18, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Plugin stuck if retries are reached

3 participants