fix(core): rewrite Host header for Envoy compatibility #1678
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override default Director to set Host header to target URL. NewSingleHostReverseProxy preserves original Host header which causes 404 errors with Envoy-based loadbalancers in Gardener. On-behalf-of: @SAP mikolaj.kucinski@sap.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gardener started enabling Envoy for loadbalancing which routes requests based on the
Hostheader. The CORS proxy useshttputil.NewSingleHostReverseProxywhich preserves the original clientsHostheader instead of rewriting it to the target URL.Override the default
Directorfunction to rewrite theHostheader to match the target URL.What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist