fix(plugins): ensure SecretRefs are available for templating #1680
+142
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwe-mayer
previously approved these changes
Dec 18, 2025
Templating of the Plugins HelmChart could fail if a required SecretRef was not available. This change ensures that secretRefs are not filtered from the optionValues during evaluation of expression & integrated values. Also it ensures they are not removed when calculating the flux helmrelease values
This refactors the resolution of ValueFromRefs and Expressions Instead of individual processing of optionValues incl filtering and merging of results. this is now processing each value individually handling CEL expressions and tracking of integrated values
IvoGoman
force-pushed
the
fix/plugin-flux-secretRefs
branch
from
39e1d09 to
198884e
Compare
uwe-mayer
reviewed
Dec 18, 2025
uwe-mayer
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Templating of the Plugins HelmChart could fail if a required SecretRef was not available.
This change refactors the computation of the pluginOptions for the Flux controller, to handle each optionValue individually. Removing the need to copy & filter unwanted optionValues and to merge the resolved optionValues.
Also it removes a bug, where the generation of the flux HelmRelease values removes secretRefs from the optionValues.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist