Skip to content

Improve Monochart Service port mapping #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reixd wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve Monochart Service port mapping #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85a842f
Improve Monochart Service port mapping
Oct 22, 2020
1a416b4
Use default name
Oct 22, 2020
c5adae6
Merge branch 'master' into improve_monochart_service_ports
Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion incubator/monochart/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
ports:
{{- range $name, $port := .Values.service.ports }}
{{- if $port }}
- targetPort: {{ $name }}
- targetPort: {{ $port.internal }}
port: {{ $port.external }}
protocol: {{ default "TCP" $port.protocol }}
name: {{ $name }}
Expand Down
6 changes: 3 additions & 3 deletions incubator/monochart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,9 @@ service:
enabled: false
type: ClusterIP
# ports:
# name:
# internal: 80
# external: 80
# name: #Name of the Port for Multi-Port Services
# internal: 80 #This is the targetPort for the application/deployment/etc.
# external: 80 #This is the incoming port
# labels:
# name: value
# annotations:
Expand Down