[incubator/service-level-operator] Fix namespace used by the ServiceAccountBinding in chart#262
Open
bvis wants to merge 3 commits intocloudposse:masterfrom
Conversation
Signed-off-by: Basilio Vera <basilio.vera@softonic.com>
Signed-off-by: Basilio Vera <basilio.vera@softonic.com>
Signed-off-by: Basilio Vera <basilio.vera@softonic.com>
Author
|
After 22 days without any answer I'll proceed to publish my package version with the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart has hardcoded the namespace to use (
monitoring) in the ServiceAccountBinding, making the image to fail when it tries to create the CRD.Once fixed the image can create the CRD without any problem.