Fix bad yaml when only secretKeyRef

[asiegman]

Found a bug with my previous feature.

If you specified only a secretKeyRef, and not an accompanying fieldRef, the env: tag would be missing in the yaml section, causing invalid yaml as such:

      containers:
      - name: mything
        image: mything:latest
        imagePullPolicy: Always

        envFrom:
        - configMapRef:
            name: mything-env-default

          - name: MYTHING_USERNAME
            valueFrom:
              secretKeyRef:
                name: mything-user
                key: username
          - name: MYTHING_PASSWORD
            valueFrom:
              secretKeyRef:
                name: mything-user
                key: password

This fixes this bug, so that if either fieldKeyRef or secretKeyRefs are referenced, the env: section will have the appropriate yaml

      containers:
      - name: mything
        image: mything:latest
        imagePullPolicy: Always

        envFrom:
        - configMapRef:
            name: mything-env-default

        env:

          - name: MYTHING_USERNAME
            valueFrom:
              secretKeyRef:
                name: mything-user
                key: username
          - name: MYTHING_PASSWORD
            valueFrom:
              secretKeyRef:
                name: mything-user
                key: password

[Nuru]

You need to consider

charts/incubator/monochart/templates/_helpers.tpl

Lines 57 to 63 in 37a41f5

	{{- with $root.Values.env }}
	env:
	{{- range $name, $value := . }}
	- name: {{ $name }}
	value: {{ default "" $value | quote }}
	{{- end }}
	{{- end }}

And you can use a more concise syntax like

charts/incubator/monochart/templates/_helpers.tpl

Line 26 in 37a41f5

{{- if $root.Values.configMaps | or $root.Values.secrets | or $root.Values.envFrom }}

• empty is redundant, conditionals calculate emptiness for you

[asiegman]

I really didn't like my if statement there, but missed the better syntax. Updated that.

Is the forced quoting of values for safety? I didn't see it done in the fieldRef feature just above the secretKeyRef feature, so I did not do it. This is all part of the following Kubernetes features:
https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets-as-environment-variables

This should all be Kubernetes field paths and secret names and safe for YAML without unnecessary quoting. I'm always a bit fuzzy on this, the rules around quoting in YAML seem inconsistent to me everytime I read them.

[asiegman]

Added in the string safety after testing it. Seems Kubernetes doesn't mind the explicit strings there, in my limited testing.