feat: synthetics, adding http_version entries in options_list and request_definition. #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also I could enhance the examples catalogue to show these settings. Maintainers please let me know if you want that. |
atrull
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Enabling http_version entries in options_list and request_definition.
why
Datadog has some issues with certain endpoints which require http2 enforcement to pass checks.
options_list is not yet respected by multistep API checks despite being marked as 'going away, use options_list' in the provider, so we include the request_definition method for setting this.
references
Discussion with Datadog Support Engineer.