fix(stdio): iterate over decoded messages list#241
Open
b-serra wants to merge 1 commit intocloudwalk:mainfrom
Open
fix(stdio): iterate over decoded messages list#241b-serra wants to merge 1 commit intocloudwalk:mainfrom
b-serra wants to merge 1 commit intocloudwalk:mainfrom
Conversation
Message.decode/1 returns a list of messages, but process_message/2 expects a single message (map). This caused a BadMapError when processing any incoming stdio message. The fix properly iterates over the decoded messages list using Enum.each/2 before calling process_message/2 for each message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #240
Message.decode/1returns a list of messages, butprocess_message/2expects a single message (map). This caused aBadMapErrorwhen processing any incoming stdio message.Changes
Enum.each/2before callingprocess_message/2for each messageBefore (broken)
After (fixed)
Testing