roundID type changed from int to string #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpell
approved these changes
Jan 20, 2026
Member
nickpell
left a comment
nickpell
left a comment
There was a problem hiding this comment.
Looks good! One question about backwards compatibility.
| Type string `json:"type"` | ||
| AuctionID string `json:"auction_id"` | ||
| RoundID int `json:"round_id"` | ||
| RoundID string `json:"round_id"` |
Member
There was a problem hiding this comment.
Is there any accompanying PR for SSP that handles backwards compatibility?
Member
There was a problem hiding this comment.
I found the corresponding PR - it looks like backwards compatibility is not maintained. Could you make sure we maintain compatibility during all phases of updating these services?
Member
There was a problem hiding this comment.
Possibly just needs a custom serializer/deserializer method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to have unique auction round id, that would hold auction id within.
For example, if auctionID value (that is BidRequest.id) is:
Then auction round id, for that auction first round would be:
Opened improved solution PR here