refactor: extract shared types and deprecate kataka fields (Wave 3A, #375)

[cmbays]

Summary

Final wiring pass for the CooldownSession decomposition (#375):

• Extract shared types to cooldown-types.ts — BetOutcomeRecord, IncompleteRunInfo, CooldownSessionResult, CooldownPrepareResult moved out of the orchestrator. 10 import sites updated, re-exports maintain backward compat.
• @deprecated tags on kataka legacy fields — katakaConfidenceCalculator and katakaDir in both CooldownSessionDeps and CooldownBeltDeps.
• Remove unused BeltComputeResult import from cooldown-session.ts.

Decomposition Summary (all 6 PRs)

Wave	Service	Lines	PR
1A	BridgeRunSyncer	195L	#396
1B	CooldownBeltComputer	85L	#397
2A	CooldownFollowUpRunner	124L	#398
2B	CooldownDiaryWriter	191L	#399
2C	CooldownSynthesisManager	273L	#400
3A	Type extraction + deprecation	this PR

CooldownSession: 1,359 → 673 lines (-51%)

Quality Gates

• Verify (lint + typecheck + unit + integration + e2e + build): PASS
• 113 BDD acceptance scenarios: PASS
• dep-cruiser (394 modules): zero violations
• ArchUnit: 14 of 15 (pre-existing CycleManager LCOM4)
• CRAP: all cooldown files < threshold
• Mutation: 85.03% (threshold 70%)

Closes #375

Test plan

• npm run verify — full suite passes
• npm run test:acceptance — 113 BDD scenarios
• npm run test:arch — dep-cruiser clean
• npm run test:arch:unit — 14 of 15 ArchUnit rules
• npm run test:crap — cooldown files all clean
• npm run test:mutation — 85.03%

Summary by CodeRabbit

• Chores
  • Added deprecation notices for legacy configuration parameters katakaConfidenceCalculator and katakaDir. Migrate to agentConfidenceCalculator and agentDir respectively before v1 removal.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0247a65e-89c8-4f76-bd9f-71452ca319b4

📥 Commits

Reviewing files that changed from the base of the PR and between f735014 and 9ab4d2a.

📒 Files selected for processing (11)

• src/features/cycle-management/bridge-run-syncer.steps.ts
• src/features/cycle-management/bridge-run-syncer.test.ts
• src/features/cycle-management/bridge-run-syncer.ts
• src/features/cycle-management/cooldown-belt-computer.ts
• src/features/cycle-management/cooldown-diary-writer.steps.ts
• src/features/cycle-management/cooldown-diary-writer.test.ts
• src/features/cycle-management/cooldown-diary-writer.ts
• src/features/cycle-management/cooldown-session.ts
• src/features/cycle-management/cooldown-types.ts
• src/features/dojo/diary-writer.test.ts
• src/features/dojo/diary-writer.ts

---

📝 Walkthrough

Walkthrough

This PR reorganizes cooldown-related type definitions by extracting IncompleteRunInfo, BetOutcomeRecord, CooldownSessionResult, and CooldownPrepareResult from cooldown-session.ts into a new dedicated module cooldown-types.ts. Multiple consumers update their imports, while cooldown-session.ts re-exports these types for backward compatibility. Deprecation markers are added to legacy dependency aliases in CooldownBeltDeps.

Changes

Cohort / File(s)	Summary
Type Definition Extraction src/features/cycle-management/cooldown-types.ts	New module defining four exported type interfaces: IncompleteRunInfo, BetOutcomeRecord, CooldownSessionResult (with optional fields for artifacts), and CooldownPrepareResult (prepare-stage variant without completion timestamps).
Session Module Refactoring src/features/cycle-management/cooldown-session.ts	Removed local type declarations, added imports and re-exports from cooldown-types.js for backward compatibility. Added @deprecated JSDoc markers to katakaConfidenceCalculator and katakaDir properties. Removed unused BeltComputeResult import.
Bridge & Diary Import Updates src/features/cycle-management/bridge-run-syncer.ts, src/features/cycle-management/bridge-run-syncer.steps.ts, src/features/cycle-management/bridge-run-syncer.test.ts, src/features/cycle-management/cooldown-diary-writer.ts, src/features/cycle-management/cooldown-diary-writer.steps.ts, src/features/cycle-management/cooldown-diary-writer.test.ts	Updated BetOutcomeRecord and IncompleteRunInfo imports to source from ./cooldown-types.js instead of ./cooldown-session.js.
Dojo Diary Import Updates src/features/dojo/diary-writer.ts, src/features/dojo/diary-writer.test.ts	Updated BetOutcomeRecord import to source from @features/cycle-management/cooldown-types.js instead of @features/cycle-management/cooldown-session.js.
Deprecation Markers src/features/cycle-management/cooldown-belt-computer.ts	Added JSDoc @deprecated annotations to katakaConfidenceCalculator (replaced by agentConfidenceCalculator) and katakaDir (replaced by agentDir) properties in CooldownBeltDeps interface.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• refactor: extract CooldownDiaryWriter from CooldownSession (Wave 2B, #375) #399 — Both PRs modify cycle-management diary/session code and the same cooldown types (e.g., BetOutcomeRecord, IncompleteRunInfo), with this PR extracting those types to a dedicated module while the related PR refactored diary/session logic that consumes them.
• refactor: extract BridgeRunSyncer from CooldownSession (Wave 1A) #396 — Both PRs modify the same bridge-run-syncer.ts and cooldown-session.ts files; this PR extracts cooldown types and updates imports, while the related PR extracted BridgeRunSyncer logic.
• feat(dojo): personal training environment for Kata (Wave K) #172 — The type extraction and re-export of cooldown types in this PR directly intersects with the related PR's changes to cooldown-session/diary integration and type consumers.

Poem

🐰 Types freed from tangled session threads,
Now nestled in their cozy cooldown bed,
Old aliases fade with gentle @deprecated grace,
While bridges and diaries find their new import place!
A cleaner split, a lighter load—
The refactoring road brings order to the code. 📚✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch wave-3a-final-wiring

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}