Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 95.75% 95.81% +0.05%
==========================================
Files 8 8
Lines 730 740 +10
==========================================
+ Hits 699 709 +10
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| if not self._beep: | ||
| self._logger.debug("Disable nuzzer") | ||
| props["Buzzer_ON_OFF"] = 1 |
There was a problem hiding this comment.
Since this is just a standard property, please implement it through the generic property handling via _properties. If it's possible to read this property, we should read it from the device as well so that the state can properly be reported back to clients (such as in homeassistant).
However, if the property is unsupported, that might cause a problem with the read/write requests and cause the requests to be dropped by the device making it unusable. It might be possible to limit availability of this property based on the versions strings coming back after binding.
There was a problem hiding this comment.
As I know, this is not a property (part of device state).
It disables BEEP only when the controller applies the received command.
Next command without "Buzzer_ON_OFF" will generate a BEEP regardless of previous commands.
Actually, it's a property of the connection/client but not part of the device state.
There was a problem hiding this comment.
any news here guys? I'm really interested on it and happy to help
4 participants
Add ability to disable beep.
In my case, it does not work on one firmware version (1.23) but works on next one (1.31).