Allow filter chains to start with a missing variable#496
Open
rydrman wants to merge 4 commits intocobalt-org:masterfrom
Open
Allow filter chains to start with a missing variable#496rydrman wants to merge 4 commits intocobalt-org:masterfrom
rydrman wants to merge 4 commits intocobalt-org:masterfrom
Conversation
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
…hain Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
Author
|
I'm not sure why the AppVeyor build failed, it seems to be something outside of the scope of this PR |
|
@epage any thoughts on this? |
|
I'd love to see this land, but it looks pretty stale - reading #477 it's unclear to me - is the resolution that this should or should not be the correct behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #477, this change treats missing variables and indexes as
nilwhen they appear at the start of a filter chain. As far as I can tell, this is in line with the shopify implementation.I needed a way to properly identify when an error identified a missing index or variable, and so introduced the concept of an
ErrorKindto handle this. If there is a better or preferred way, please let me know!closes #477