Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-11184

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 963c0dd
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/690e504293e3aa00082a4564

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 963c0dd
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/690e50426056e60008179029

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Files changed:

@netlify
Copy link

netlify bot commented Oct 30, 2025

Netlify Preview

Name Link
🔨 Latest commit 963c0dd
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/690e50424b77fa000838ff96
😎 Deploy Preview https://deploy-preview-20876--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland force-pushed the 20251030-DOC-11184-dont-disable-tsdata branch 3 times, most recently from 739b23e to 0eb897d Compare November 7, 2025 16:02
Copy link
Contributor

@bsanchez-the-roach bsanchez-the-roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, otherwise is looking good!

Copy link
Contributor

@bsanchez-the-roach bsanchez-the-roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmloveland
Copy link
Contributor Author

rmloveland commented Nov 7, 2025

Thanks for the review @bsanchez-the-roach ! Backporting to supported versions v23.2+ before merge

Fixes DOC-11184

NB. These changes are backported to supported versions v23.2+
@rmloveland rmloveland force-pushed the 20251030-DOC-11184-dont-disable-tsdata branch from bbd298d to abb5818 Compare November 7, 2025 20:01
@rmloveland rmloveland enabled auto-merge (squash) November 7, 2025 20:02
@rmloveland rmloveland merged commit 0a706c5 into main Nov 7, 2025
6 checks passed
@rmloveland rmloveland deleted the 20251030-DOC-11184-dont-disable-tsdata branch November 7, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants