Skip to content

DOC-15338: Remove metrics from Essential Metrics Advanced page #20972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DOC-15338: Remove metrics from Essential Metrics Advanced page #20972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/current/_includes/v25.4/essential-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% assign version = page.version.version | replace: ".", "" %}
{% assign advanced_excluded_metrics = "sys.cpu.host.combined.percent-normalized|sys.host.disk.iopsinprogress|sql.mem.root.current|storage.write-stalls" | split: "|" %}
{% comment %}DEBUG: {{ version }}{% endcomment %}

{% comment %} STEP 1. Assign variables specific to deployment {% endcomment %}
Expand Down Expand Up @@ -122,7 +123,9 @@ The **Usage** column explains why each metric is important to visualize and how
{% for metric in essential_metrics %}
{% comment %} STEP 4d. Exclude SQL metrics that will be placed in special categories {% endcomment %}
{% unless category_name == SQL %}
{% unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats" %}
{% comment %} Hide metrics that should not appear for advanced deployment {% endcomment %}
{% unless include.deployment == 'advanced' and advanced_excluded_metrics contains metric.name %}
{% unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats" %}

{% comment %} Transforms to match datadog_id {% endcomment %}
{% assign input_metric = metric.name %}
Expand Down Expand Up @@ -162,7 +165,8 @@ The **Usage** column explains why each metric is important to visualize and how
<td>{{ metric.how_to_use }}</td>
</tr>

{% endunless %}{% comment %}unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats"{% endcomment %}
{% endunless %}{% comment %}unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats"{% endcomment %}
{% endunless %}{% comment %}unless metric is excluded for advanced deployment{% endcomment %}
{% endunless %}{% comment %}unless category_name == SQL{% endcomment %}
{% endfor %}{% comment %}for metric in essential_metrics{% endcomment %}
{% endfor %}{% comment %}for layer in layer_names_array{% endcomment %}
Expand Down Expand Up @@ -296,4 +300,4 @@ The **Usage** column explains why each metric is important to visualize and how
- [Visualize metrics in Grafana]({% link {{ page.version.version }}/monitor-cockroachdb-with-prometheus.md %}#step-5-visualize-metrics-in-grafana)
- [Custom Chart Debug Page]({% link {{ page.version.version }}/ui-custom-chart-debug-page.md %})
- [Cluster API]({% link {{ page.version.version }}/cluster-api.md %})
- [Essential Alerts]({% link {{ page.version.version }}/essential-alerts-self-hosted.md %})
- [Essential Alerts]({% link {{ page.version.version }}/essential-alerts-self-hosted.md %})
Loading