Feat/cf 2149 CVE 66414 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added questionable ts-ignore
Contributor
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @modelcontextprotocol/sdk dependency from version 1.0.1 to 1.25.2 to address security vulnerabilities (CVE related to the qs transitive dependency). The code is refactored to use the new McpServer class instead of the deprecated Server class.
Changes:
- Updated
@modelcontextprotocol/sdkfrom version 1.0.1 to 1.25.2 - Migrated from deprecated
ServertoMcpServerwrapper class - Updated all server method calls to use
mcpServer.serveraccessor pattern
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Bumps the MCP SDK dependency from 1.0.1 to 1.25.2 to address security vulnerabilities |
| index.ts | Refactors code to use McpServer instead of deprecated Server, updates import statement, renames variable from server to mcpServer, and adds type suppression for triggers capability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Turns out these triggers were never used in the first place (custom property). For now to satisfy the compiler I have removed them.
manufacturist
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@modelcontextprotocol/sdkServertoMCPServer(which wrapsServer)