Allow to upload files in editors #24
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for general file uploads (not just images) in editor fields by introducing a new File toolbar button and associated configuration methods.
- Added
OzuEditorToolbarButton::Fileenum case for file upload functionality - Implemented
setAllowedExtensions()method to control which file types can be uploaded - Updated
setMaxFileSize()validation to work with both Image and File upload buttons
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OzuCms/Form/OzuEditorToolbarButton.php | Added new File enum case for general file upload button |
| src/OzuCms/Form/OzuEditorField.php | Added allowedExtensions property and setAllowedExtensions() method; updated validation logic for setMaxFileSize() to support both Image and File uploads |
| tests/Unit/OzuEditorFieldTest.php | Added comprehensive test coverage for new file upload functionality including validation, normalization, and conditional inclusion of allowed extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/OzuCms/Form/OzuEditorField.php
Outdated
|
|
||
| private int $maxFileSize = 5; | ||
|
|
||
| private array $allowedExtensions = ['.jpg', '.jpeg', '.png', '.gif', '.bmp', '.svg', '.webp']; |
There was a problem hiding this comment.
The default allowedExtensions value contains only image extensions (.jpg, .jpeg, .png, etc.), which may not be appropriate when the File toolbar button is enabled for general file uploads. Consider having different defaults based on whether Image or File button is used, or making this more flexible to handle non-image file types.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…to add-file-in-editors
No description provided.