This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Open
Conversation
added 2 commits
February 29, 2020 22:51
RaduCStefanescu
requested review from
RaduCStefanescu,
cosminbosutar and
gheorghelupu17
Comment on lines
+29
to
+30
| // $exist = Volunteer::query()->where('ssn', '=', $value)->first(); | ||
| // if (strlen($value) === 13 && !$exist) { |
Contributor
There was a problem hiding this comment.
Please delete the lines that are no longer needed.
| $rules = [ | ||
| 'organisation_id' => 'required', | ||
| 'email' => 'required|string|email|max:255|unique:volunteers.volunteers', | ||
| // 'email' => 'required|string|email|max:255|unique:volunteers.volunteers', |
Contributor
There was a problem hiding this comment.
Please remove old line and a comment to explain what the login of "VolunteerEmail" rule.
Comment on lines
+298
to
+327
| /** if is specified only a course */ | ||
| $course_name_id = $request->has('course_name_id') ? $request->course_name_id : ''; | ||
| if (trim($course_name_id)!='') { | ||
| $course_name = CourseName::find($course_name_id); | ||
| if ($course_name) { | ||
| /** Create a new course. */ | ||
| $newCourse = [ | ||
| 'course_name' => [ | ||
| '_id' => $course_name['_id'], | ||
| 'name' => $course_name['name'], | ||
| 'slug' => removeDiacritics($course_name['name'])], | ||
| 'obtained' => Carbon::parse($request->get('obtained',''))->format('Y-m-d H:i:s') | ||
| ]; | ||
| /** Check if the accreditor already exists in DB. */ | ||
| $courseAccreditor = CourseAccreditor::query()->where('name', '=', $request->get('accredited_by',''))->first(); | ||
| if (!$courseAccreditor) { | ||
| $courseAccreditor = CourseAccreditor::create(['name' => $request->get('accredited_by',''), 'courses' => [$course_name['_id']]]); | ||
| } else { | ||
| if (is_array($courseAccreditor->courses) && !in_array($course_name['_id'], $courseAccreditor->courses)) { | ||
| $courseAccreditor->courses = array_merge( $courseAccreditor->courses, [$course_name['_id']]); | ||
| $courseAccreditor->save(); | ||
| } | ||
| } | ||
| /** Save the accreditor and add the course to the volunteer. */ | ||
| $newCourse['accredited'] = ['_id' => $courseAccreditor->_id,'name' => $courseAccreditor->name]; | ||
| $data['courses'][] = $newCourse; | ||
| $volunteer->courses = $data['courses']; | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Have you tested this?
So in case only one course was added to a volunteer, that course was ignored?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.