This repository was archived by the owner on Oct 24, 2023. It is now read-only.
made toolbar responsive when there are more items#199
Open
minodora-c wants to merge 3 commits intocode4romania:masterfrom
Open
made toolbar responsive when there are more items#199minodora-c wants to merge 3 commits intocode4romania:masterfrom
minodora-c wants to merge 3 commits intocode4romania:masterfrom
Conversation
adjusted the toolbar so that parts of the menu gets hidden when the screen is smaller and there are many toolbar items
sdecianu
reviewed
Mar 3, 2022
sdecianu
reviewed
Mar 3, 2022
|
I like the solution especially because it works :) The code is just fine. Have you tried a mobile-sized screen to see how it behaves? Or perhaps another browser (i.e. Safari, since that's the most widely used non-Chrome browser) |
Author
|
I'll finish it off tomorrow and try it in Mozilla too :) |
Author
|
it works in Mozilla and in Chrome's simulation of mobile phones :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #187
adjusted the toolbar so that parts of the menu gets hidden when the screen is smaller and there are many toolbar items:
RVM.-.Google.Chrome.2022-03-03.11-40-04.compressed.mp4
Every time the window is resized, the menu is re-adjusted.
If you like this solution, lemme know, and I can finish it off by applying a bit more CSS so it looks a bit better :)