Conversation
simina424
requested review from
alexandru-calinoiu,
catileptic,
idormenco and
pirvudoru
as code owners
danielferecatu
approved these changes
Jan 27, 2024
danielferecatu
left a comment
danielferecatu
left a comment
There was a problem hiding this comment.
All in all, I'd say it can be merged. My comments can be done in a separate PR.
There was a problem hiding this comment.
Please rename the file to match the contents.
|
|
||
| namespace TeacherWorkout.Domain.Common | ||
| { | ||
| public interface IContext |
There was a problem hiding this comment.
Please extract the interface into a separate file.
|
PR moved to #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it fix?
WIP Issue #14
Closes #XXX
How has it been tested?
Te rog sa verifici daca mai sunt necesare modificair in fisierul de stratup privind user, ca am modificarile in fisier.