Return 400 for invalid instance registration payloads#5125
Open
amacharla15 wants to merge 2 commits intocodecentric:masterfrom
Open
Return 400 for invalid instance registration payloads#5125amacharla15 wants to merge 2 commits intocodecentric:masterfrom
amacharla15 wants to merge 2 commits intocodecentric:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Map invalid /instances registration payloads to 400 BAD_REQUEST instead of surfacing as 500.
Add integration tests covering invalid JSON, missing name, and missing healthUrl.
How to run:
./mvnw -pl spring-boot-admin-server -Dtest=InstancesControllerIntegrationTest test
Evidence:
Before: invalid registration could surface as 500.
Now: tests fail if invalid payloads don’t return 400.