Never skip .git when copying repo to temp#68
Merged
Conversation
… skipped. This change improves the handling of ignored files by explicitly allowing the .git directory, even if specified in .gitignore files.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…s contents. This update ensures that any files within the .git directory are treated correctly, improving the handling of ignored files in version control.
rohitpaulk
approved these changes
Jan 14, 2026
Member
rohitpaulk
left a comment
rohitpaulk
left a comment
There was a problem hiding this comment.
@andy1li let's add tests for this
…tents are not skipped. Added new test cases to ensure proper handling of paths related to the .git directory, reinforcing the logic implemented in the GitIgnore functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When users have .git in their gitignore files, it breaks the CLI.
Note
Low Risk
Small, targeted guard in path-filtering logic with added tests; risk is limited to edge cases in path matching and may slightly reduce ignore behavior for unconventional
.git-named paths.Overview
Prevents the CLI from accidentally excluding repository metadata when users ignore
.git.GitIgnore.SkipFilenow explicitly returns not skipped for the.gitdirectory and anything under it before checking local/global ignore rules (including.git/info/exclude). Tests add coverage ensuring.gitand common nested/absolute.gitpaths are never skipped even if.gitignorecontains patterns like.gitor.git/*.Written by Cursor Bugbot for commit c779ecc. This will update automatically on new commits. Configure here.