Merged
Conversation
…improve cleanup error handling. This enhances the robustness of directory operations and ensures warnings are displayed if cleanup fails.
Member
Author
|
Thanks to @GregMarshall999 for highlighting the issue! |
rohitpaulk
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
https://secure.helpscout.net/conversation/3244692401/11524?viewId=8414074
Without -LiteralPath, this error can happen:
Note
Low Risk
Low risk: only tweaks Windows installer script path checks and temp cleanup behavior, with minimal impact beyond more reliable installs and slightly different cleanup failure handling.
Overview
Improves the Windows
install.ps1script’s robustness by switchingTest-Pathcalls to-LiteralPathfor both the install directory and temp directory checks, avoiding failures with special characters in paths.Also hardens temp-folder cleanup by wrapping
Remove-Itemin atry/catch, using-ErrorAction Stop, and emitting a warning if cleanup fails instead of silently ignoring errors.Written by Cursor Bugbot for commit b371668. This will update automatically on new commits. Configure here.