Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
internal/test_helpers/scenarios/background_jobs_job_number_not_recycled/main.py
Outdated
Show resolved
Hide resolved
- Fix Bug 1: Move return statement outside for loop in main.py (line 92) to process all background jobs instead of returning after the first one - Fix Bug 2: Add ExpectedOutputAndRegex() method to BackgroundJobStatusEntry to centralize job entry formatting logic. Update both CommandResponseWithReapedJobsTestCase and JobsBuiltinResponseTestCase to use the shared method, including proper 'Running' status handling.
…es-f553 Jobs command issues
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rohitpaulk
approved these changes
Feb 26, 2026
| [33m[your-program] [0m[0m$ echo mango[0m | ||
| [33m[your-program] [0m[0mmango[0m | ||
| [33m[your-program] [0m[0m[1]+ Done grep -q raspberry /tmp/pear-70[0m | ||
| [33m[tester::#FY4] [0m[92m✓ Received command output followed by an entry for the reaped job[0m |
Member
There was a problem hiding this comment.
Let's add a test for when the command output is not followed by an entry
Contributor
Author
There was a problem hiding this comment.
Added another command test case following this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds new background-jobs stages and assertions that change the tester’s expected output ordering and job-number semantics, which could introduce flaky process-timing or output-matching issues. Changes are test-harness scoped (not runtime application code) but affect core stage validation.
Overview
Adds Background Jobs stages 7–8 (
bv8,fy4) to validate (1) completed jobs are reaped and printed before the next prompt/command output, and (2) job numbers are recycled/reset after all jobs are reaped (including across a shell restart).Updates the tester harness accordingly: introduces
CommandResponseWithReapedJobsTestCaseto assert command output followed by reaped-job lines, refactorsjobsoutput expectations intoBackgroundJobStatusEntrywith a sharedExpectedOutputAndRegex()builder, and wires the new stages intotester_definition,stages_test, course definition, Makefile stage lists, and fixtures (including a new failing scenario for non-recycled job numbers).Written by Cursor Bugbot for commit 7b26cc1. This will update automatically on new commits. Configure here.