Contributing to App Code

Getting Started

1. Get an account on the Docassemble Playground (instructions pinned in #clean-slate-app too)
   1. At the top right of the page (on https://interviews-dev.gbls.org) , there is a sign-in/signup button. Just click that and follow along to register.
   2. Click on your username in the top right - it’s a drop down - and click on 'Profile'.
   3. On that page, click the button for 'Other settings'. That's a drop down too.
   4. Select 'request developer account'
   5. Check if you now have a different menu. If not, go to the next step.
   6. Post in the Slack channel to let us know you’ve done that and we can let our partner know so they can approve it.
2. Set up your Github account in the Playground (for now, ask someone about how to do that)
3. DO NOT CREATE A FORK OF THE REPO for this purpose. Forks make it hard for reviewers to try out PRs.
4. Set up a new 'Project' (for now, ask someone about how to do that)
5. Request to be added as a collaborator on https://github.com/codeforboston/docassemble-juvenilesealing
6. In the Playground, in your Project, go to the 'Packages' folder and pull the master branch from https://github.com/codeforboston/docassemble-juvenilesealing
7. Make edits
8. Pick a name for a NEW BRANCH. Use the following naming convention: number-short-description. For example, if you're working on issue 42, simplifying the language in the form, you could name it 42-plain-language.
9. Create the NEW BRANCH on https://github.com/codeforboston/docassemble-juvenilesealing.
10. Make a PR from that branch to the master branch.

Deleting Files (harder than you think)

If you don't follow a specific procedure, deleted files won't stay deleted.

The Docassemble Playground lets you push to and pull from Github. It's very basic, though, and interacts with Docassemble's Playground files in weird ways. When one person deletes a file, everyone on the team has to go through a process to make sure that file stays deleted.

When someone else deletes a file

1. Someone merge their changes into the master branch.
2. Pull the latest code from the master branch.
3. In Playground, go to your Project.
4. Then go to Folders > Package Management > Files.
5. Using cmd+click or ctrl+click, un-highlight the to-be-deleted files in all the lists of files in the lower part of the page.
6. On that page, hit the 'Save' (button's at the bottom).
7. Go to edit each of the files to be deleted and click 'Delete' on each one.
8. Push all your changes (not sure if this one is needed, especially since it'd be pushing to a new branch).

When you're deleting a file

1. Create a new branch.
2. You can use a cloned local version or you can do this in github.
3. Find all the files manually in the repo. If you can't find one, ask for help.
4. Delete it.
5. If you did this on your local machine, push your changes to that new branch.
6. Follow the instructions above.