Conversation
…ter/GamesDat into feat/udp-base-source
There was a problem hiding this comment.
Pull request overview
Adds Formula 1 (EA/Codemasters) UDP telemetry ingestion support to the GamesDat telemetry pipeline, along with a WPF demo “real-time” source and binary fixtures for validating packet parsing across multiple game years.
Changes:
- Introduces a reusable UDP telemetry source base + options.
- Adds Formula 1 packet models (2022–2025) and a realtime F1 UDP source that routes packets by (format, packet id).
- Updates the WPF demo to surface an F1 realtime source and adds F1 packet fixture binaries (2023–2025).
Reviewed changes
Copilot reviewed 150 out of 206 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| GamesDat/Telemetry/Sources/UdpSourceOptions.cs | Adds configurable UDP listener options. |
| GamesDat/Telemetry/Sources/UdpSourceBase.cs | Implements common UDP async read loop. |
| GamesDat/Telemetry/Sources/Formula1/Specifications/README.md | Documents where to store official UDP specs. |
| GamesDat/Telemetry/Sources/Formula1/PacketId.cs | Defines F1 packet id enum. |
| GamesDat/Telemetry/Sources/Formula1/LiveryColour.cs | Adds livery colour struct definition. |
| GamesDat/Telemetry/Sources/Formula1/F1TelemetryFrameExtensions.cs | Adds helpers to map/deserialize frames. |
| GamesDat/Telemetry/Sources/Formula1/F1TelemetryFrame.cs | Adds raw telemetry frame container struct. |
| GamesDat/Telemetry/Sources/Formula1/F1RealtimeTelemetrySource.cs | Adds realtime UDP source for F1 packets. |
| GamesDat/Telemetry/Sources/Formula1/F12025/WeatherForecastSample.cs | Adds 2025 weather forecast sample struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/TyreStintHistoryData.cs | Adds 2025 tyre stint history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/TyreSetData.cs | Adds 2025 tyre set struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/TimeTrialDataSet.cs | Adds 2025 time trial dataset struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/ParticipantData.cs | Adds 2025 participants packet struct (naming differs). |
| GamesDat/Telemetry/Sources/Formula1/F12025/Participant.cs | Adds 2025 participant struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketTyreSetsData.cs | Adds 2025 tyre sets packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketTimeTrialData.cs | Adds 2025 time trial packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketSessionHistoryData.cs | Adds 2025 session history packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketMotionExData.cs | Adds 2025 extended motion packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketLobbyInfoData.cs | Adds 2025 lobby info packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketLapPositionsData.cs | Adds 2025 lap positions packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketLapData.cs | Adds 2025 lap data packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketHeader.cs | Adds 2025 packet header struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketFinalClassificationData.cs | Adds 2025 final classification packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketCarStatusData.cs | Adds 2025 car status packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/PacketCarDamageData.cs | Adds 2025 car damage packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/MotionData.cs | Adds 2025 motion packet struct (naming differs). |
| GamesDat/Telemetry/Sources/Formula1/F12025/MarshalZone.cs | Adds 2025 marshal zone struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/LobbyInfoData.cs | Adds 2025 lobby player struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/LapHistoryData.cs | Adds 2025 lap history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/LapData.cs | Adds 2025 lap data struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/FinalClassificationData.cs | Adds 2025 final classification entry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/EventData.cs | Adds 2025 event packet struct + helper. |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarTelemetryData.cs | Adds 2025 car telemetry packet struct (naming differs). |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarTelemetry.cs | Adds 2025 per-car telemetry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarStatusData.cs | Adds 2025 per-car status struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarSetupData.cs | Adds 2025 car setup packet struct (naming differs). |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarSetup.cs | Adds 2025 per-car setup struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarMotionData.cs | Adds 2025 per-car motion struct. |
| GamesDat/Telemetry/Sources/Formula1/F12025/CarDamageData.cs | Adds 2025 per-car damage struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/WeatherForecastSample.cs | Adds 2024 weather forecast sample struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/TyreStintHistoryData.cs | Adds 2024 tyre stint history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/TyreSetData.cs | Adds 2024 tyre set struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/TimeTrialDataSet.cs | Adds 2024 time trial dataset struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/ParticipantData.cs | Adds 2024 participant struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketTyreSetsData.cs | Adds 2024 tyre sets packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketTimeTrialData.cs | Adds 2024 time trial packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketSessionHistoryData.cs | Adds 2024 session history packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketParticipantsData.cs | Adds 2024 participants packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketMotionExData.cs | Adds 2024 extended motion packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketMotionData.cs | Adds 2024 motion packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketLobbyInfoData.cs | Adds 2024 lobby info packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketLapData.cs | Adds 2024 lap data packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketHeader.cs | Adds 2024 packet header struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketFinalClassificationData.cs | Adds 2024 final classification packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketEventData.cs | Adds 2024 event packet struct + helper. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketCarTelemetryData.cs | Adds 2024 car telemetry packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketCarStatusData.cs | Adds 2024 car status packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketCarSetupData.cs | Adds 2024 car setup packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/PacketCarDamageData.cs | Adds 2024 car damage packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/MarshalZone.cs | Adds 2024 marshal zone struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/LobbyInfoData.cs | Adds 2024 lobby player struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/LapHistoryData.cs | Adds 2024 lap history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/LapData.cs | Adds 2024 per-car lap struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/FinalClassificationData.cs | Adds 2024 classification entry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/CarTelemetryData.cs | Adds 2024 per-car telemetry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/CarStatusData.cs | Adds 2024 per-car status struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/CarSetupData.cs | Adds 2024 per-car setup struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/CarMotionData.cs | Adds 2024 per-car motion struct. |
| GamesDat/Telemetry/Sources/Formula1/F12024/CarDamageData.cs | Adds 2024 per-car damage struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/WeatherForecastSample.cs | Adds 2023 weather forecast sample struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/TyreStintHistoryData.cs | Adds 2023 tyre stint history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/TyreSetData.cs | Adds 2023 tyre set struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/ParticipantData.cs | Adds 2023 participant struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketTyreSetsData.cs | Adds 2023 tyre sets packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketSessionHistoryData.cs | Adds 2023 session history packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketParticipantsData.cs | Adds 2023 participants packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketMotionExData.cs | Adds 2023 extended motion packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketMotionData.cs | Adds 2023 motion packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketLobbyInfoData.cs | Adds 2023 lobby info packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketLapData.cs | Adds 2023 lap data packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketHeader.cs | Adds 2023 packet header struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketFinalClassificationData.cs | Adds 2023 final classification packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketEventData.cs | Adds 2023 event packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketCarTelemetryData.cs | Adds 2023 car telemetry packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketCarStatusData.cs | Adds 2023 car status packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketCarSetupData.cs | Adds 2023 car setup packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/PacketCarDamageData.cs | Adds 2023 car damage packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/MarshalZone.cs | Adds 2023 marshal zone struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/LobbyInfoData.cs | Adds 2023 lobby player struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/LapHistoryData.cs | Adds 2023 lap history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/LapData.cs | Adds 2023 per-car lap struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/FinalClassificationData.cs | Adds 2023 classification entry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/EventDataDetails.cs | Adds 2023 event union + subtypes. |
| GamesDat/Telemetry/Sources/Formula1/F12023/CarTelemetryData.cs | Adds 2023 per-car telemetry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/CarStatusData.cs | Adds 2023 per-car status struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/CarSetupData.cs | Adds 2023 per-car setup struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/CarMotionData.cs | Adds 2023 per-car motion struct. |
| GamesDat/Telemetry/Sources/Formula1/F12023/CarDamageData.cs | Adds 2023 per-car damage struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/WeatherForecastSample.cs | Adds 2022 weather forecast sample struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/TyreStintHistoryData.cs | Adds 2022 tyre stint history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/ParticipantData.cs | Adds 2022 participant struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketSessionHistoryData.cs | Adds 2022 session history packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketSessionData.cs | Adds 2022 session packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketParticipantsData.cs | Adds 2022 participants packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketMotionData.cs | Adds 2022 motion packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketLobbyInfoData.cs | Adds 2022 lobby info packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketLapData.cs | Adds 2022 lap data packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketHeader.cs | Adds 2022 packet header struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketFinalClassificationData.cs | Adds 2022 final classification packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketEventData.cs | Adds 2022 event packet struct + helper. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketCarTelemetryData.cs | Adds 2022 car telemetry packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketCarStatusData.cs | Adds 2022 car status packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketCarSetupData.cs | Adds 2022 car setup packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/PacketCarDamageData.cs | Adds 2022 car damage packet struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/MarshalZone.cs | Adds 2022 marshal zone struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/LobbyInfoData.cs | Adds 2022 lobby player struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/LapHistoryData.cs | Adds 2022 lap history struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/LapData.cs | Adds 2022 per-car lap struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/FinalClassificationData.cs | Adds 2022 classification entry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/CarTelemetryData.cs | Adds 2022 per-car telemetry struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/CarStatusData.cs | Adds 2022 per-car status struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/CarSetupData.cs | Adds 2022 per-car setup struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/CarMotionData.cs | Adds 2022 per-car motion struct. |
| GamesDat/Telemetry/Sources/Formula1/F12022/CarDamageData.cs | Adds 2022 per-car damage struct. |
| GamesDat/Telemetry/Sources/Formula1/EventCodes.cs | Adds F1 event code constants. |
| GamesDat/GamesDat.Core.csproj | Adds folders (Solution Explorer grouping). |
| GamesDat/.claude/settings.local.json | Adds Claude local tool allowlist (should stay local). |
| GamesDat.Tests/Fixtures/F1/2025/packet-0.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-1.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-2.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-BUTN.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-COLL.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-FLBK.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-FTLP.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-LGOT.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-OVTK.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-PENA.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-RCWN.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-RTMT.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-SEND.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-SPTP.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-SSTA.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-STLG.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-3-TMPT.bin | Adds 2025 event fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-4.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-5.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-6.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-7.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-8.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-10.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-11.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-12.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-13.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-14.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2025/packet-15.bin | Adds 2025 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-0.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-1.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-2.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-3.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-4.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-5.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-6.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-7.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-10.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-11.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-12.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-13.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2024/packet-14.bin | Adds 2024 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-0.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-1.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-2.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-3.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-4.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-5.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-6.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-7.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-8.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-10.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-11.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-12.bin | Adds 2023 fixture packet. |
| GamesDat.Tests/Fixtures/F1/2023/packet-13.bin | Adds 2023 fixture packet. |
| GamesDat.Demo.Wpf/ViewModels/RealtimeTabViewModel.cs | Adds F1 source + uses IRealtimeSource list. |
| GamesDat.Demo.Wpf/ViewModels/RealtimeSourceViewModel.cs | Switches to IRealtimeSource interface. |
| GamesDat.Demo.Wpf/ViewModels/IRealtimeSource.cs | Introduces common realtime source interface. |
| GamesDat.Demo.Wpf/Resources/Styles.xaml | Adds new converter resources (types missing). |
| GamesDat.Demo.Wpf/Properties/launchSettings.json | Adds DEBUG env var for local runs. |
| GamesDat.Demo.Wpf/GamesDat.Demo.Wpf.csproj | Changes output type to Exe. |
| .gitignore | Ignores Claude local settings and DebugTooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codegefluester I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Björn Kaiser <masterchiefs2002@hotmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Björn Kaiser <masterchiefs2002@hotmail.com>
|
@codegefluester I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@codegefluester I've opened a new pull request, #7, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@codegefluester I've opened a new pull request, #8, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@codegefluester I've opened a new pull request, #9, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@codegefluester I've opened a new pull request, #10, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 150 out of 206 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Initial plan * Fix: Change m_zoneFlag from byte to sbyte in F12025 MarshalZone Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
* Initial plan * Apply BufferSize to socket's ReceiveBufferSize property Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
* Initial plan * Refactor UdpSourceBase to use Dispose pattern instead of manual disposal in finally block Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Add thread-safety to Dispose method in UdpSourceBase Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Move base.Dispose() inside lock for better thread-safety Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Set disposed flag before disposal operations for better exception safety Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Add try-finally to ensure base.Dispose() is always called Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
* Initial plan * Make LiveryColour fields public to allow access Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
* Initial plan * Remove unused BytesToStruct method from F1RealtimeTelemetrySource Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
…10) * Initial plan * Remove .claude/settings.local.json files from repository * Push changes - removed .claude/settings.local.json files Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Remove .claude/settings.local.json files and update .gitignore pattern --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 151 out of 207 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@codegefluester I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you. |
) * Initial plan * Fix unsafe fixed buffer pointer handling and UTF-8 marshaling - Fix F1TelemetryFrameExtensions to use Unsafe.Read<T> and direct pointer access for fixed buffers - Change F12025 Participant m_name from ByValTStr to byte array for proper UTF-8 marshaling - UdpSourceBase Dispose() implementation already correct (from previous PR) Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Add Name property helper for UTF-8 decoded participant name Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Fix AccessViolationException in GetPacket by using Unsafe.AsPointer Use Unsafe.AsPointer(ref frame.RawData[0]) instead of Unsafe.Read to properly get a pointer to the fixed buffer. This resolves both the CS0213 compilation error and the runtime AccessViolationException. Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Fix frame extension and test --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> Co-authored-by: Björn Kaiser <bjoern@codegefluester.de>
No description provided.