Fix visual frame evidence to show actual video frame indices#20
Merged
Conversation
- Store video frame rate (fps) as instance variable during metadata extraction - Calculate actual video frame indices based on timestamp and fps - Update frame discontinuity analysis to track both extraction indices and video frame indices - Modify visual evidence display to show actual video frame numbers instead of extraction indices - Add helper methods for timestamp and file size formatting - Update HTML template to clarify these are 'Video Frame' indices - Store actual file sizes from analysis instead of hardcoded values Fixes CG-19004: Frame indices now represent actual position within video rather than just download order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CG-19004: Updates the visual frame evidence display to show actual video frame indices instead of just the extraction indices.
Problem
Previously, the visual frame evidence showed "Frame 2" and "Frame 3" which were just the sequential extraction indices (frame_002.png, frame_003.png). These numbers didn't represent the actual position within the video, making the evidence confusing and less meaningful.
Solution
Changes Made
Core Logic (
epstein_video_analyzer.py)self.fpsinstance variable to store video frame rateanalyze_frame_discontinuities()to calculate actual video frame indices_format_timestamp()and_format_file_size()helper methodsTemplate (
templates/report.html)Testing
test_frame_indices.pyto verify frame calculation logicExample Output
Before:
After:
Now the frame numbers represent the actual position within the video (at ~29.97 fps), making the forensic evidence much more meaningful and accurate.
Testing
Run the test script to verify the calculations:
The changes maintain backward compatibility while providing more accurate and meaningful frame evidence for forensic analysis.
💻 View my work • About Codegen