docs: switch to code syntax for parsing examples#9470
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Mar 1, 2025
Merged
docs: switch to code syntax for parsing examples#9470paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan merged 1 commit intocodeigniter4:developfrom
Conversation
Member
|
I don't recall ever using plug-ins. Do I understand correctly that quotation marks are entirely disallowed around plugin parameters? |
Member
|
I've reviewed the source code of the plugins, and quotes are IMO recommended. The issue seems to arise when copying examples from the user guide, where quotes are formatted as curly or smart quotes, which aren't parsed correctly in PHP. We should consider using code syntax for our examples rather than plain text. This should resolve the issue. |
e05e765 to
d502ef6
Compare
Contributor
Author
michalsn
approved these changes
Mar 1, 2025
paulbalandan
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Some template tags, such as {+ siteURL "login" +}, had extra quotation marks that caused parsing errors. We've resolved this by switching to code syntax for examples, ensuring correct interpretation and execution of the tags.
Checklist: