Skip to content

refactor: revert property promotion on Exceptions#9995

Merged
paulbalandan merged 1 commit intocodeigniter4:4.8from
paulbalandan:revert-cpp-exceptions
Feb 24, 2026
Merged

refactor: revert property promotion on Exceptions#9995
paulbalandan merged 1 commit intocodeigniter4:4.8from
paulbalandan:revert-cpp-exceptions

Conversation

@paulbalandan
Copy link
Member

Description
I promoted the $config in Exceptions without realizing it may break existing extended classes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added refactor Pull requests that refactor code 4.8 PRs that target the `4.8` branch. labels Feb 23, 2026
@paulbalandan paulbalandan merged commit 1172c8c into codeigniter4:4.8 Feb 24, 2026
49 checks passed
@paulbalandan paulbalandan deleted the revert-cpp-exceptions branch February 24, 2026 04:34
JulianAtkins pushed a commit to JulianAtkins/CodeIgniter4 that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants