ImageViewer: add optional navigation arrows and thumbnail strip with theming and tests

[shai-almog]

Motivation

• Provide optional on-screen navigation controls for ImageViewer to improve UX when using image lists, including side arrows and a bottom thumbnail strip.
• Allow configuring these affordances via theme constants so designers can enable them globally for the ImageViewer UIID.

Description

• Added fields and API to ImageViewer to support navigation arrows and a thumbnail bar: navigationArrowsVisible, thumbnailsVisible, thumbnailBarHeightMM, plus getters/setters and getPointerActionAt, getThumbnailIndexAt, navigateTo/navigateToLeft/navigateToRight helpers.
• Implemented painting of the chrome with drawNavigationChrome, drawArrow, and drawThumbnails, and integrated this into the main paint flow.
• Integrated theme constant initialization in initThemeConstants to read imageviewerNavigationArrowsBool, imageviewerThumbnailsBool, and imageviewerThumbnailBarHeightMM, with robust parsing helper.
• Exposed the new options via the property API by extending getPropertyNames, getPropertyTypes, getPropertyTypeNames, getPropertyValue, and setPropertyValue.
• Added pointer handling to support tapping arrows and thumbnails (press/release action detection), and early-return behavior during drags when an action is detected.
• Updated documentation in Advanced-Theming.asciidoc and The-Components-Of-Codename-One.asciidoc describing the new theme constants and usage.
• Added unit test updates in ImageViewerTest to assert new properties and thumbnail behavior, and added a screenshot/demo test ImageViewerNavigationScreenshotTest and registered it in the device test runner.

Testing

• Ran the ImageViewer unit tests via mvn -Dtest=com.codename1.components.ImageViewerTest test, which includes the updated propertyAccessorsExposeConfiguration and the new thumbnailTapNavigatesToSpecificImage test, and they passed.
• The project builds with the new ImageViewerNavigationScreenshotTest added and the test is included in the CN1SS device runner smoke suite; the screenshot test compiles within the test harness.

---

Codex Task

[github-actions]

Developer Guide build artifacts are available for download from this workflow run:

• Developer Guide HTML package
• Developer Guide PDF
• AsciiDoc linter report
• Vale report
• Unused image report

Developer Guide quality checks:

• AsciiDoc linter: No issues found (report)
• Vale: 18818 alert(s) (2768 errors, 6382 warnings, 9668 suggestions) (exit code 1) (report)
• Image references: No unused images detected (report)

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2303 total, 0 failed, 0 skipped
• 📊 Line coverage: 53.03% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.util.EasyThread$InQueueRunnable – 0.00%
    • com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
    • com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
    • com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
    • com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
    • com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
    • com.codename1.ui.ElevationComparator – 0.00%
    • com.codename1.ui.spinner.TimeSpinner3D$MinuteRowFormatter – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 94 more
  • ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 409 more
  • ❌ codenameone-maven-plugin: 477 findings (High: 1, Normal: 313, Low: 163)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 474 more
  • ✅ core-unittests: 0 findings (no issues)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 32 screenshots: 32 matched.

Native Android coverage

• 📊 Line coverage: 7.27% (3696/50867 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.69% (18209/320093), branch 2.74% (851/31113), complexity 3.40% (1010/29746), method 5.97% (828/13858), class 9.78% (179/1831)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 7.27% (3696/50867 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.69% (18209/320093), branch 2.74% (851/31113), complexity 3.40% (1010/29746), method 5.97% (828/13858), class 9.78% (179/1831)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

[shai-almog]

Compared 32 screenshots: 32 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

• VM Translation Time: 340 seconds
• Compilation Time: 254 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	28080 ms
Extract Extensions	19 ms
Google Services Setup	3 ms
Scan Classes	598 ms
Extract Libs	1060 ms
Inject Build Hints	40 ms
Generate Unit Tests	3 ms
Generate Stubs	789 ms
Compile Stubs	1907 ms
Generate Icons	775 ms
Prepare ParparVM	154 ms
ParparVM Execution	204013 ms
Post-VM Setup	291 ms
CocoaPods	6785 ms
Finalize	72 ms
Total Time	244591 msMaven Overhead : 96000 ms
CocoaPods Install (Script)	2000 ms
Simulator Boot	91000 ms
Simulator Boot (Run)	2000 ms
App Install	20000 ms
App Launch	2000 ms
Test Execution	148000 ms