Update HelloCodenameOne to use Java 17 and add Java 17 language test by shai-almog · Pull Request #4588 · codenameone/CodenameOne

shai-almog · 2026-03-04T19:16:26Z

Motivation

Move the HelloCodenameOne sample to Java 17 so developers can use modern language features in the sample and tests.
Provide a small unit test that verifies Java 17 syntax (features that do not require new API surface) compiles and runs under the sample test harness.

Description

Updated project-level properties in scripts/hellocodenameone/pom.xml to set java.version, java-tests.version, compiler source/target, and kotlin.compiler.jvmTarget to 17.
Updated platform module POMs (javase, android, ios, javascript, win) to set maven.compiler.source/target to 17.
Changed scripts/hellocodenameone/common/codenameone_settings.properties to request Java 17 (codename1.arg.java.version=17).
Enhanced run/build scripts on Unix and Windows (run.sh/build.sh, run.bat/build.bat) to prefer and export a JDK 17 JAVA_HOME when available before invoking the Maven wrapper.
Added Java17LanguageFeaturesTest under scripts/hellocodenameone/common/src/test/java/... that exercises var, switch expression, and text blocks to validate Java 17 language compilation in tests.
Documented the Java 17 requirement in scripts/hellocodenameone/README.adoc.

Testing

Ran bash ./run.sh help in scripts/hellocodenameone and it printed help successfully (passed).
Ran bash ./build.sh help in scripts/hellocodenameone and it printed help successfully (passed).
Attempted cd scripts/hellocodenameone && ./mvnw -pl common -DskipTests=false test -Dcodename1.platform=javase which failed in this environment due to the Maven wrapper bootstrap encountering a network error while resolving the wrapper distribution (failed here due to environment/network).
Attempted cd scripts/hellocodenameone && mvn -pl common -DskipTests=false test -Dcodename1.platform=javase which failed because com.codenameone:codenameone-maven-plugin:8.0-SNAPSHOT could not be resolved from configured repositories (plugin resolution failure in this environment).

Codex Task

github-actions · 2026-03-05T05:19:41Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2314 total, 0 failed, 0 skipped
📊 Line coverage: 53.18% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%
  - com.codename1.ui.spinner.TimeSpinner3D$MinuteRowFormatter – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 94 more
- ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 409 more
- ❌ codenameone-maven-plugin: 477 findings (High: 1, Normal: 313, Low: 163)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 474 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-03-05T05:23:48Z

Compared 32 screenshots: 32 matched.

Native Android coverage

📊 Line coverage: 7.30% (3711/50862 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.65% (18061/319659), branch 2.75% (857/31113), complexity 3.40% (1011/29741), method 5.98% (828/13853), class 9.63% (176/1827)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.30% (3711/50862 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.65% (18061/319659), branch 2.75% (857/31113), complexity 3.40% (1011/29741), method 5.98% (828/13853), class 9.63% (176/1827)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

github-actions · 2026-03-05T14:23:38Z

✅ ByteCodeTranslator Quality Report

Test & Coverage

✅ Tests: 146 total, 0 failed, 2 skipped

Benchmark Results

Execution Time: 9494 ms
Hotspots (Top 20 sampled methods):
- 20.74% java.lang.String.indexOf (343 samples)
- 18.62% com.codename1.tools.translator.Parser.isMethodUsed (308 samples)
- 11.49% java.util.ArrayList.indexOf (190 samples)
- 8.46% com.codename1.tools.translator.Parser.addToConstantPool (140 samples)
- 4.17% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (69 samples)
- 4.11% java.lang.Object.hashCode (68 samples)
- 3.26% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (54 samples)
- 2.60% com.codename1.tools.translator.BytecodeMethod.optimize (43 samples)
- 2.42% java.lang.System.identityHashCode (40 samples)
- 1.75% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (29 samples)
- 1.69% com.codename1.tools.translator.BytecodeMethod.equals (28 samples)
- 1.33% com.codename1.tools.translator.ByteCodeClass.markDependent (22 samples)
- 1.09% com.codename1.tools.translator.ByteCodeClass.fillVirtualMethodTable (18 samples)
- 1.03% com.codename1.tools.translator.Parser.cullMethods (17 samples)
- 1.03% java.lang.StringBuilder.append (17 samples)
- 0.85% sun.nio.ch.FileDispatcherImpl.write0 (14 samples)
- 0.85% sun.nio.fs.UnixNativeDispatcher.open0 (14 samples)
- 0.60% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (10 samples)
- 0.60% java.lang.StringCoding.encode (10 samples)
- 0.54% java.io.UnixFileSystem.getBooleanAttributes0 (9 samples)
⚠️ Coverage report not generated.

Static Analysis

✅ SpotBugs: no findings (report was not generated by the build).
⚠️ PMD report not generated.
⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>

Update HelloCodenameOne scripts and tests for Java 17

1c3b76d

shai-almog added the codex label Mar 4, 2026 — with ChatGPT Codex Connector

shai-almog added 3 commits March 4, 2026 21:33

Fix HelloCodenameOne test compiler level to Java 17

81ca9b9

Make Java 17 language test opt-in and restore Java 8 defaults

1ed1a7f

Restore Java 17 HelloCN1 setup and relax Java version parsing

ff41ada

shai-almog added 2 commits March 5, 2026 08:17

Make HelloCodenameOne Maven wrapper prefer JDK 17

1d1a059

Add StringConcatFactory stubs to JavaAPI and CLDC11

b1aafb5

shai-almog added 3 commits March 5, 2026 16:31

Use JDK 17 in iOS scripts workflow for HelloCodenameOne build

65fe9d4

Use JAVA17_HOME for iOS app Maven build

2d1e791

Merge branch 'master' into codex/update-hellocodenameone-for-java-17

594cc84

Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>

shai-almog closed this Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update HelloCodenameOne to use Java 17 and add Java 17 language test#4588

Update HelloCodenameOne to use Java 17 and add Java 17 language test#4588
shai-almog wants to merge 9 commits intomasterfrom
codex/update-hellocodenameone-for-java-17

shai-almog commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

shai-almog commented Mar 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented Mar 4, 2026

Motivation

Description

Testing

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ ByteCodeTranslator Quality Report

Test & Coverage

Benchmark Results

Static Analysis

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Mar 5, 2026 •

edited

Loading

shai-almog commented Mar 5, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading