Migrate build tools and example projects to Java 17 and add compatibility fixes#4591
Closed
shai-almog wants to merge 2 commits intomasterfrom
Closed
Migrate build tools and example projects to Java 17 and add compatibility fixes#4591shai-almog wants to merge 2 commits intomasterfrom
shai-almog wants to merge 2 commits intomasterfrom
Conversation
…sy9wvg Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 32 screenshots: 32 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
✅ ByteCodeTranslator Quality ReportTest & Coverage
Benchmark Results
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
java.versionwith the Maven compiler target when they differ.StringConcatFactoryto satisfy Java API expectations in the VM/Ports sources.Description
actions/setup-java@v4for the macOS iOS build job.StringConcatFactorystub classes underPorts/CLDC11andvm/JavaAPIto avoid missing-symbol issues for string concat support.CN1BuildMojo) to parse Java version strings via a newparseJavaVersionhelper and to override the build requestjava.versionwhenmaven.compiler.targetis higher than the request, logging the change.parseJavaVersionhelper and used it inInstallCn1libsMojoto robustly compare library and projectcodename1.arg.java.versionvalues.hellocodenameoneproject and modulepom.xmlfiles to target Java 17 (maven.compiler.source/targetand project properties), and updated top-level properties tojava.version=17and test compile targets.mvnw,mvnw.cmd,build.sh,run.sh,build.bat,run.bat,build-ios-app.sh) to prefer or locate a JDK 17 installation and to setJAVA_HOME/PATHfor Maven invocations;build-ios-app.shswitchesJAVA_HOMEtoJAVA17_HOMEfor iOS Maven builds.Java17LanguageFeaturesTestto the examplecommontests to validate typical Java 17 language constructs compile in tests, and updated the example README to note Java 17 usage.Testing
Java17LanguageFeaturesTestwas added to the example project to exercise Java 17 language features (compilation assertion).Codex Task