Skip to content

Conversation

@hgp22
Copy link
Contributor

@hgp22 hgp22 commented Sep 20, 2025

No description provided.

@hgp22 hgp22 changed the title feat: change page link to pt & fix responsiveness in page component feat: recruitment page Sep 21, 2025
@pedrofp4444 pedrofp4444 linked an issue Sep 21, 2025 that may be closed by this pull request
@hgp22 hgp22 marked this pull request as ready for review September 24, 2025 14:56
@hgp22
Copy link
Contributor Author

hgp22 commented Sep 24, 2025

Altough this pr is open to review, there are things that still need work and furthermore, I need your opinion based on the page look.


The component Pages received an improve in the underline part, so that it fits the title (regardless of length).

Extra: I think that each card should be a component and that the buttons should be aligned.

@hgp22 hgp22 requested a review from pedrofp4444 September 24, 2025 15:02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the data/ directory instead of the assets/ one the store the FAQs information, we should uniformize this either by choosing one directory or the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put onto the data/ dir 🙏

@pedrofp4444
Copy link
Member

Regarding the overall proposal, I really like the option of placing the cards with a carousel underneath, as I believe it conveys the information quite well. The carousel would also slow down the navigation slightly, giving users more time to actually read the content.

For the cards, I think it’s essential that they maintain a consistent identity and design across all elements. With that in mind, I believe it would be valuable to include images in every card, as this helps build credibility and adds a more human touch.

That said, I also really like the current site layout for this page. What do you think about displaying one card per row across all devices, with vertical responsiveness only, while keeping the horizontal alignment and always totaling three rows? This would look similar to the current setup, but using shadcn-vue cards.

@hgp22
Copy link
Contributor Author

hgp22 commented Sep 25, 2025

@pedrofp4444

it would be valuable to include images in every card

Where can I get more images?

What do you think about displaying one card per row across all devices, with vertical responsiveness only, while keeping the horizontal alignment and always totaling three rows?

Sounds good, it already has that behaviour for mobile (and it already uses shadcn-vue cards)

@pedrofp4444
Copy link
Member

Where can I get more images?

The best place to do so it's the NAS where we centralize all the images, I'll contact @helderrrg to clarify that.

Sounds good, it already has that behaviour for mobile (and it already uses shadcn-vue cards)

That's exactly it!

@pedrofp4444
Copy link
Member

Also, I'm not sure if the present result is what you finally pretended but I was suggesting having the cards occupying the whole free space in the page, just like this:

image

Then, in mobile versions I would get rid of the excessive margin. 🙏

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recruitment Page

3 participants