Skip to content

Conversation

@MatousJobanek
Copy link
Collaborator

@openshift-ci openshift-ci bot requested review from jrosental and xcoulon December 22, 2025 15:08
@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Warning

Rate limit exceeded

@MatousJobanek has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c4598f6 and b1e4e1c.

📒 Files selected for processing (3)
  • deploy/crds/cdi.kubevirt.io_datavolumes.yaml
  • test/e2e/parallel/user_workloads_test.go
  • testsupport/wait/member.go
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

return createPvcWithPod(t, memberAwait, name, namespace, createdDataVolume)
}

func createPvcWithPod(t *testing.T, memberAwait *wait.MemberAwaitility, name, namespace string, owner client.Object) *corev1.Pod {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is a preparation for upcoming PR that will support also deletion of PVCs (I found some pods that are owned by a PVC that doesn't have any owner)

@sonarqubecloud
Copy link

@MatousJobanek
Copy link
Collaborator Author

MatousJobanek commented Dec 23, 2025

/retest
flaky - should be fixed by #1212

@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2025

@MatousJobanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e b1e4e1c link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant