Skip to content

Replace defaultProps with default function parameters in components #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tchiss wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace defaultProps with default function parameters in components #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,23 @@ import PropTypes from 'prop-types';
import { Image } from 'react-native';
import * as flags from './src';

const Flag = props => {
const flag = flags[props.type][`icons${props.size}`][props.code];
const unknownFlag = flags[props.type][`icons${props.size}`]['unknown'];
const Flag = ({ size = 64, type = "shiny", code, style }) => {
const flag = flags[type][`icons${size}`][code];
const unknownFlag = flags[type][`icons${size}`]['unknown'];

return (
<Image
source={flag || unknownFlag}
style={[{ width: props.size, height: props.size }, props.style]}
/>
<Image
source={flag || unknownFlag}
style={[{ width: size, height: size }, style]}
/>
);
};

Flag.propTypes = {
size: PropTypes.number,
type: PropTypes.string,
};

Flag.defaultProps = {
size: 64,
type: "shiny",
code: PropTypes.string.isRequired,
style: PropTypes.object,
};

export default Flag;