fix(ci): Windows SIGILL in CI #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
changed the title
Hoping this fixing failing tests in windows ci
emizzle
force-pushed
the
ci/fix-illegal-operation
branch
from
a8013df to
4fb6056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the SIGILL in windows ci, which indicates that nim was being built with an illegal instruction set. By specifying --march=x86_64, it tells gcc to enable a more compatible (generic) set of cpu instructions. See https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html#index-march-15 for more info.
Also reverts "excludes" from test import as it is no longer needed.