Skip to content

Testing improvements #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArtOfCode- merged 89 commits into from
Jul 23, 2025
Merged

Testing improvements #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
71dc1af
renamed check_posts_permissions to get_accessible_posts to match its …
Oaphi Jan 12, 2025
6e75e63
renamed get_accessible_posts to accessible_posts_for (per @ArtOfCode-…
Oaphi Jan 12, 2025
914375d
parametrized user for search_posts & qualifiers_to_sql methods of Sea…
Oaphi Jan 12, 2025
c06d4e9
added unit test for :user search qualifier
Oaphi Jan 12, 2025
f7a048e
added unit test for :status search qualifier
Oaphi Jan 12, 2025
78a165f
added unit test for :score search qualifier
Oaphi Jan 12, 2025
e4f7ffc
added unit test for :upvotes qualifier
Oaphi Jan 13, 2025
46851fd
added unit test for :downvotes qualifier
Oaphi Jan 13, 2025
78b9657
added unit test for :net_votes qualifier
Oaphi Jan 13, 2025
8f0eb44
moved category access check into SearchHelper#accessible_categories_f…
Oaphi Jan 13, 2025
ae8e5f1
added User#mod_or_admin? QoL method for access checks
Oaphi Jan 13, 2025
23f841d
mods or admins should be able to access all categories when searching
Oaphi Jan 13, 2025
cdc5aea
added unit test for :category qualifier
Oaphi Jan 13, 2025
f2368ff
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jan 16, 2025
a69e708
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jan 26, 2025
739fed3
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Mar 24, 2025
08cf18f
added storage directory to gitignore to prevent accidental commits of…
Oaphi May 8, 2025
89c0526
added YARD for SearchHelper#search_posts (prevents needing to solve a…
Oaphi Jul 11, 2025
57cd00d
made SearchHelper#accessible_categories_for a class method on Categor…
Oaphi Jul 11, 2025
be1887c
made SearchHelper#accessible_posts_for a class method on Post [access…
Oaphi Jul 11, 2025
8e21b73
moved mod_or_admin? around to avoid having to solve yet another nasty…
Oaphi Jul 11, 2025
24b41b3
accidentally committed Gemfile.lock update (one less merge conflict t…
Oaphi Jul 11, 2025
aa673e4
moving YARD SearchHelper#qualifiers_to_sql from develop (avoiding the…
Oaphi Jul 11, 2025
d3996ba
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 11, 2025
3b07e00
syncing with develop: User#mod_or_admin? is now User#at_least_moderator?
Oaphi Jul 11, 2025
4e9bf06
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 12, 2025
1270525
let's setup Rubcop CI while we are at it
Oaphi Jul 12, 2025
ad961f8
uhm, do we really need rubocop-rake in GH Actions?
Oaphi Jul 12, 2025
212ac9d
let's not shout, shall we (Rubocop GH Actions setup)?
Oaphi Jul 12, 2025
d9b7836
installing rubocop-rake directly won't hurt
Oaphi Jul 12, 2025
299bc09
apparently, excluding vendor directory is a must for GitHub Actions
Oaphi Jul 12, 2025
6bbfe2b
let's see if Ruby 3.1 testing works
Oaphi Jul 12, 2025
11d998e
let's make RAILS_ENV a workflow-level var
Oaphi Jul 12, 2025
bb17e1c
now let's add MYSQL to the testing action
Oaphi Jul 12, 2025
f7ee020
ports is an array, duh
Oaphi Jul 12, 2025
92a7fe2
welp, there's no way to set service container entrypoint options, let…
Oaphi Jul 12, 2025
4e3f19b
now add Rails for our testing workflow, won't work without it
Oaphi Jul 12, 2025
bb45351
expose Redis service container port 6379
Oaphi Jul 12, 2025
f95e58b
add Ruby 3.2 testing via GH Actions matrix
Oaphi Jul 12, 2025
02b634d
testing system tests & screenshots
Oaphi Jul 12, 2025
c8cf464
let's see if setup-firefox is any good
Oaphi Jul 13, 2025
772d268
minor testing workflow updates & temp check for where the heck are sc…
Oaphi Jul 13, 2025
2cae369
I hope this is the correct path for screenshot artifacts
Oaphi Jul 13, 2025
3bc884c
final touch for system tests: remove the dummy screenshot test case
Oaphi Jul 13, 2025
dce725f
renamed admin_only category fixture to disambiguate from high_trust
Oaphi Jul 13, 2025
666702b
no, search_posts does not return an ActiveRecord::Relation, but a 2-t…
Oaphi Jul 13, 2025
c2613d7
simplified search_posts helper YARD
Oaphi Jul 13, 2025
1fbd9be
made search_string an explicit parameter of search_posts (so as it ca…
Oaphi Jul 13, 2025
03d2865
switched search_posts & params_to_qualifiers to accept params directly
Oaphi Jul 13, 2025
6c15022
added test for checking that search_posts never returns posts from ca…
Oaphi Jul 13, 2025
e4a6fc6
added missing staff user community user fixture
Oaphi Jul 13, 2025
5eb01f3
added User#can_see_category? access control method
Oaphi Jul 13, 2025
a10f0da
restored User#trust_level to prevent errors on users with no communit…
Oaphi Jul 13, 2025
0f5f17f
made User#can_see_category? more robust
Oaphi Jul 13, 2025
47b9431
added Category#public? access control method
Oaphi Jul 13, 2025
0d5a104
made CategoriesController#verify_view_access action callback more robust
Oaphi Jul 13, 2025
da9fae5
we don't even have trust level 6
Oaphi Jul 13, 2025
12ccb1e
added test for checking that categories with high trust level to view…
Oaphi Jul 13, 2025
72d6bdc
made categories controller :show test cover all cases
Oaphi Jul 13, 2025
baa38f8
added try_create_category test helper method
Oaphi Jul 13, 2025
1270732
cleaned up & expanded categories controller tests
Oaphi Jul 13, 2025
99802f5
let's dry-run CodeCov
Oaphi Jul 13, 2025
c86bd07
working on CodeCov upload actions step
Oaphi Jul 13, 2025
201067b
enabled verbose mode & CI failure on error if CodeCov fails to get co…
Oaphi Jul 13, 2025
b82407f
let's run CodeCov for real this time
Oaphi Jul 13, 2025
d384080
eh, apparently, CodeCov needs coverage output
Oaphi Jul 13, 2025
2f2b6a6
coverage option works too, let's actually upload
Oaphi Jul 13, 2025
247200a
cleaned up posts controller create tests
Oaphi Jul 14, 2025
c359b56
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 14, 2025
3ffc9be
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 17, 2025
2b374e6
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 21, 2025
a7fc02e
bumped rubocop-rake to 0.7.1
Oaphi Jul 21, 2025
b9441e4
size.zero? <=> empty? (Rubocop)
Oaphi Jul 21, 2025
1c53be6
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 22, 2025
6b58734
let's see how a merged workflow goes
Oaphi Jul 22, 2025
a8a3a0b
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 22, 2025
c8e9a70
here goes nothing - testing deployments
Oaphi Jul 22, 2025
dde6596
whoops, yaml...
Oaphi Jul 22, 2025
69046cf
quick test - do we have extra keys in?
Oaphi Jul 22, 2025
14af669
let's see if verbose mode yields anything of use
Oaphi Jul 22, 2025
e57813e
drop base64 decoding & check SSH version
Oaphi Jul 22, 2025
4c7c92d
this ssh command order makes more sense
Oaphi Jul 22, 2025
441e81f
don't even try keyboard & pwd auth
Oaphi Jul 22, 2025
8f4f3d3
restore full pipeline and test
Oaphi Jul 22, 2025
14ce76c
run deploy only on push to develop
Oaphi Jul 22, 2025
9554b26
go away, CircleCI
Oaphi Jul 22, 2025
84638af
renamed main workflow to ci-cd
Oaphi Jul 22, 2025
bd3904e
CircleCI badge is not needed anymore
Oaphi Jul 22, 2025
527c09b
proudly disply the new status badge
Oaphi Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
337 changes: 0 additions & 337 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

Loading
Loading