Skip to content

Conversation

@cellio
Copy link
Member

@cellio cellio commented Dec 8, 2025

Fixes #1921

I find it a little puzzling that in the JS code that implements the keyboard options, 'k' came before 'j' and the values were flipped. Perhaps a previous edit flipped them from what was written originally? Git blame did not bring me enlightenment.

@cellio cellio requested a review from Oaphi December 8, 2025 15:24
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (9dce9b1) to head (35b479e).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 74.66% <ø> (ø)
helpers 84.91% <ø> (-0.49%) ⬇️
jobs 79.24% <ø> (ø)
models 90.01% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - it's been like this from the start, just a minor oversight

@Oaphi Oaphi merged commit fc35aa9 into develop Dec 8, 2025
13 checks passed
@Oaphi Oaphi deleted the cellio/1921-fix-keyboard-next-prev branch December 8, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keyboard 'next' and 'previous' are flipped

3 participants