Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Dec 13, 2025

closes #1925

@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (9dce9b1) to head (f09e760).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 74.66% <ø> (ø)
helpers 84.91% <ø> (-0.49%) ⬇️
jobs 79.24% <ø> (ø)
models 90.01% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi changed the title Acount for text fragments when autoexpanding post history items Account for text fragments when autoexpanding post history items Dec 13, 2025
Copy link
Contributor

@trichoplax trichoplax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see more jQuery being retired.

The functionality of each previous jQuery line is replicated without the vulnerability to text fragment directives in the URL, so this looks complete to me, and I've approved.

The only comments I've made are a matter of personal preference where I can't guess what will be easier to read for different people, so I've just listed some thoughts. I'm fine with this being merged as is though.

Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on my dev server with the URL http://localhost:3000/posts/46/history#2:~: and it went to the correct history entry. I don't know what:~: is supposed to do (I got that from the bug report), but it doesn't do something obviously bad now. If @trichoplax (who understands the problem more than I do) is happy, I'm happy.

@Oaphi
Copy link
Member Author

Oaphi commented Dec 14, 2025

I don't know what:~: is supposed to do

As a quick FYI, :~: is a part of URI text fragments (that allow browsers to highlight specific parts of a given resource's text content) that delimits their start - it's called fragment directive. The syntax can be a bit hard to parse, but on the bright side, it's unlikely that such a sequence can be encountered as part of the actual hash (a.k.a. "fragment").

@Oaphi Oaphi merged commit 578ef87 into develop Dec 14, 2025
16 of 20 checks passed
@Oaphi Oaphi deleted the 0valt/1925/post-history-hashes branch December 14, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/history's history-events do not open when their relevant id= has a fragment directive appended.

5 participants