Skip to content

Conversation

@matthew-hennefarth
Copy link
Contributor

Closes #10. Open to changing the name of the configuration variable.

@codybuell
Copy link
Owner

Hey @matthew-hennefarth, just getting to this now. So according to RFC 5322 single quotes are not allowed. It's double quotes or nothing, double quotes only being required if special characters are required. So, that said, we ought to change the default.

If we change the default to just be double quotes do you still have a need to make this configurable?

@codybuell codybuell self-assigned this Feb 1, 2025
@matthew-hennefarth
Copy link
Contributor Author

If the standard is either double or no quotes, then it should be just a boolean. use_quotes = true if double quotes should surround the name and use_quotes = false for no quotes. The default could be then to use double quotes.

@codybuell
Copy link
Owner

That works for me, both on the boolean and default of true.

@matthew-hennefarth
Copy link
Contributor Author

matthew-hennefarth commented Feb 1, 2025 via email

@matthew-hennefarth
Copy link
Contributor Author

Okay, PR now has a boolean use_quotes which specifies if names should be surrounded by double quotes. I have also included the link to the RFC 5322 reference in the README.md.

@codybuell
Copy link
Owner

Great! Thanks for the contribution!

@codybuell codybuell merged commit e79dc63 into codybuell:master Feb 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option for Character which surrounds name

2 participants