-
Notifications
You must be signed in to change notification settings - Fork 6
[CDF-25330] ⬇ Download datapoints #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # cognite_toolkit/_cdf_tk/feature_flags.py # tests/test_unit/test_cdf_tk/test_storageio/test_selectors.py
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
- Coverage 84.63% 84.61% -0.02%
==========================================
Files 281 281
Lines 27762 27886 +124
==========================================
+ Hits 23496 23596 +100
- Misses 4266 4290 +24
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the scaffolding for downloading datapoints and includes related refactoring. The review has identified a few critical issues that should be addressed. These include an incorrect constructor call that will cause a TypeError, a potential ZeroDivisionError in the data streaming logic, and incorrect usage of itertools.groupby which could lead to data corruption. Additionally, a minor code quality issue with a duplicate line of code was found.
Description
Bump
Changelog
Added
cdf data download datapoints.