Skip to content

Conversation

@doctrino
Copy link
Collaborator

@doctrino doctrino commented Dec 2, 2025

Description

image

Bump

  • Patch
  • Skip

Changelog

Added

  • [alpha] Support for downloading datapoints, cdf data download datapoints.

@doctrino doctrino marked this pull request as ready for review December 3, 2025 13:03
@doctrino doctrino requested review from a team as code owners December 3, 2025 13:03
# Conflicts:
#	cognite_toolkit/_cdf_tk/feature_flags.py
#	tests/test_unit/test_cdf_tk/test_storageio/test_selectors.py
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
27886 23596 85% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/commands/_download.py 85% 🟢
cognite_toolkit/_cdf_tk/commands/_migrate/command.py 95% 🟢
cognite_toolkit/_cdf_tk/feature_flags.py 100% 🟢
cognite_toolkit/_cdf_tk/storageio/_datapoints.py 79% 🟢
cognite_toolkit/_cdf_tk/storageio/selectors/init.py 100% 🟢
cognite_toolkit/_cdf_tk/storageio/selectors/_datapoints.py 98% 🟢
cognite_toolkit/_cdf_tk/utils/http_client/_data_classes.py 93% 🟢
TOTAL 93% 🟢

updated for commit: 0fa159f by action🐍

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 83.56164% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.61%. Comparing base (ca5e8c0) to head (0fa159f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cognite_toolkit/_cdf_tk/storageio/_datapoints.py 79.83% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
- Coverage   84.63%   84.61%   -0.02%     
==========================================
  Files         281      281              
  Lines       27762    27886     +124     
==========================================
+ Hits        23496    23596     +100     
- Misses       4266     4290      +24     
Files with missing lines Coverage Δ
cognite_toolkit/_cdf_tk/commands/_download.py 85.33% <100.00%> (ø)
...gnite_toolkit/_cdf_tk/commands/_migrate/command.py 95.00% <100.00%> (ø)
cognite_toolkit/_cdf_tk/feature_flags.py 100.00% <ø> (ø)
...te_toolkit/_cdf_tk/storageio/selectors/__init__.py 100.00% <ø> (ø)
...toolkit/_cdf_tk/storageio/selectors/_datapoints.py 98.11% <100.00%> (+0.61%) ⬆️
...toolkit/_cdf_tk/utils/http_client/_data_classes.py 93.02% <100.00%> (+0.16%) ⬆️
cognite_toolkit/_cdf_tk/storageio/_datapoints.py 79.34% <79.83%> (+0.83%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doctrino doctrino enabled auto-merge (squash) December 3, 2025 18:52
@doctrino
Copy link
Collaborator Author

doctrino commented Dec 3, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the scaffolding for downloading datapoints and includes related refactoring. The review has identified a few critical issues that should be addressed. These include an incorrect constructor call that will cause a TypeError, a potential ZeroDivisionError in the data streaming logic, and incorrect usage of itertools.groupby which could lead to data corruption. Additionally, a minor code quality issue with a duplicate line of code was found.

@doctrino doctrino merged commit 4ec40c0 into main Dec 4, 2025
15 checks passed
@doctrino doctrino deleted the download-datapoints branch December 4, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants