Potential fix for code scanning alert no. 3: Workflow does not contain permissions#4
Closed
colinxu2020 wants to merge 1 commit intomasterfrom
Closed
Potential fix for code scanning alert no. 3: Workflow does not contain permissions#4colinxu2020 wants to merge 1 commit intomasterfrom
colinxu2020 wants to merge 1 commit intomasterfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/colinxu2020/slhdsa/security/code-scanning/3
To fix the problem, we should explicitly restrict the
GITHUB_TOKENpermissions instead of relying on inherited defaults. The least-privilege, generally safe baseline for CI jobs that only need to read the repository iscontents: read. For this workflow, thetest,build_optimized, andbuild_unoptimizedjobs only check out code, run tests/builds, and upload artifacts; they do not push commits, modify releases, or interact with issues/PRs. Theupload_pypijob already has a job-levelpermissionsblock (id-token: write) so it is not problematic and will override any workflow-level defaults.The single best way to fix this without altering functionality is to add a workflow-root
permissionsblock settingcontents: read. This will apply to all jobs that do not define their own permissions, namelytest,build_optimized, andbuild_unoptimized. Theupload_pypijob will continue to use its ownpermissionsblock as defined. No additional imports or dependencies are required, and we do not need to change any steps. Concretely, insert:between the
name: Test And Buildline (line 4) and theon:section (line 6) in.github/workflows/ci.yml.Suggested fixes powered by Copilot Autofix. Review carefully before merging.