Skip to content

DRYD-2040: Search > Infinite search requests after creating object and relating#343

Merged
spirosdi merged 1 commit intodevelopfrom
bugfix/dryd-2040
Feb 28, 2026
Merged

DRYD-2040: Search > Infinite search requests after creating object and relating#343
spirosdi merged 1 commit intodevelopfrom
bugfix/dryd-2040

Conversation

@spirosdi
Copy link
Contributor

What does this do?
The updates include:

  • Remove searchResultsSize dependency from the search effect in SearchResults to prevent infinite search requests
  • Add onInvokeComplete callback prop to SearchResultBatchPanel and SearchResultSidebar to call when the invoke completes
  • Pass handleBatchInvokeComplete from SearchResults down through SearchResultSidebar to SearchResultBatchPanel and dispatch a search

Why are we doing this? (with JIRA link)
We need to remove the searchResultsSize dependency that was originally added in this PR #318 as it results to infinite search requests: https://collectionspace.atlassian.net/browse/DRYD-2040. The dependency was originally added, in order to refresh search results after a batch invocation.

How should this be tested? Do these changes have associated tests?
In order to test that no infinite requests are being triggered after both success responses and error ones:
Success Responses:

  1. Edit an existing Collection Object
  2. Perform a search
  3. No infinite requests should be triggered

Error Responses
Please follow the "How should this be tested" steps from here: #340

In order to test that search results are refreshed after batch invocation:
Please follow the "How should this be tested" steps from here: #318

Dependencies for merging? Releasing to production?
N/A

Has the application documentation been updated for these changes?
N/A

Did someone actually run this code to verify it works?
@spirosdi ran it locally.

Have any new accessibility violations been handled?
N/A

@spirosdi spirosdi requested a review from mikejritter February 27, 2026 20:02
@spirosdi spirosdi changed the title DRYD-2040: dispatch search after batch invoke completes; DRYD-2040: Search > Infinite search requests after creating object and relating Feb 27, 2026
Copy link
Contributor

@mikejritter mikejritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with multiple scenarios and only see a single search when required :)

I think we might be able to close DRYD-2037 now as well, right?

@spirosdi spirosdi merged commit 8e246ee into develop Feb 28, 2026
5 checks passed
@spirosdi spirosdi deleted the bugfix/dryd-2040 branch February 28, 2026 05:58
@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (b83b356) to head (85f09a9).
⚠️ Report is 2 commits behind head on develop.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #343   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spirosdi
Copy link
Contributor Author

Tested with multiple scenarios and only see a single search when required :)

I think we might be able to close DRYD-2037 now as well, right?

Yes, let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants