DRYD-2040: Search > Infinite search requests after creating object and relating#343
DRYD-2040: Search > Infinite search requests after creating object and relating#343
Conversation
mikejritter
left a comment
There was a problem hiding this comment.
Tested with multiple scenarios and only see a single search when required :)
I think we might be able to close DRYD-2037 now as well, right?
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #343 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yes, let's close it. |
What does this do?
The updates include:
searchResultsSizedependency from the search effect in SearchResults to prevent infinite search requestsonInvokeCompletecallback prop to SearchResultBatchPanel and SearchResultSidebar to call when the invoke completeshandleBatchInvokeCompletefrom SearchResults down through SearchResultSidebar to SearchResultBatchPanel and dispatch a searchWhy are we doing this? (with JIRA link)
We need to remove the
searchResultsSizedependency that was originally added in this PR #318 as it results to infinite search requests: https://collectionspace.atlassian.net/browse/DRYD-2040. The dependency was originally added, in order to refresh search results after a batch invocation.How should this be tested? Do these changes have associated tests?
In order to test that no infinite requests are being triggered after both success responses and error ones:
Success Responses:
Error Responses
Please follow the "How should this be tested" steps from here: #340
In order to test that search results are refreshed after batch invocation:
Please follow the "How should this be tested" steps from here: #318
Dependencies for merging? Releasing to production?
N/A
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@spirosdi ran it locally.
Have any new accessibility violations been handled?
N/A