-
-
Notifications
You must be signed in to change notification settings - Fork 494
Add Rails 8.1 support #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/ci.yml
Outdated
| - ruby: '3.2' | ||
| gemfile: rails_8_1 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're now at ruby 3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added ruby 3.4 to the version matrix and included all the supported Ruby version for 8.1 (3.2, 3.3 & 3.4)
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
|
Hey @tirinnovo 👋 could you please review this PR again? Thanks 🙏 |
|
Following this thread |
|
👀 |
|
@danielmorrison Is this something you can help with, or relax the constraint so we don't hit it on every Rails version upgrade? I'm still using @caonUlisses' fork as I presume are many other people. This is such a great gem (and integral for lots of us); if there are problems with maintenance or it'd be better forked I'm sure plenty of us—I'd volunteer—would be happy to take on some of that responsibility! |
|
Did CI run? It's not showing that it ran.. |
|
Thanks @caonUlisses ! |
These got missed on #495 so adding them in. I've updated it according to [FastRuby's compatibility matrix](https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html).
This is pretty much a copy of this PR that added rails 8.0 support.