Opik logger fix bug with attachment to existing traces #3
+816
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug when OpikLogger didn't attach new spans to existing traces
Relevant issues
BerriAI#14282
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see details*My PR passes all unit tests onmake test-unit*- there are some failures, but they don't seem related.Type
🐛 Bug Fix
🧹 Refactoring
✅ Test
Changes
There was a regression introduced in this PR.
OpikLoggerbegan ignoring cases where existing trace IDs are passed as part of Opik metadata, causing it always to create new traces, even when it should have attached the span to an existing one.Tests pass (including the new one):
Additionally, the OpikLogger has been significantly refactored to improve its maintainability.