Skip to content

Comments

chore: use pointer receivers for PebbleDB methods#282

Merged
swift1337 merged 3 commits intocometbft:mainfrom
songgaoye:fix_pebble_next
Jan 27, 2026
Merged

chore: use pointer receivers for PebbleDB methods#282
swift1337 merged 3 commits intocometbft:mainfrom
songgaoye:fix_pebble_next

Conversation

@songgaoye
Copy link
Contributor

@songgaoye songgaoye commented Jan 23, 2026


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)

Note

Converts select PebbleDB and iterator methods to use pointer receivers to avoid value copies and ensure stateful behavior.

  • Change DeleteSync, Close, and iterator Next to pointer receivers in pebble.go
  • No logic changes to method bodies; interfaces continue to be implemented via *PebbleDB
  • Update tools/Dockerfile to add CXXFLAGS="-Wno-maybe-uninitialized" when building RocksDB to suppress compiler warnings

Written by Cursor Bugbot for commit abf2e28. This will update automatically on new commits. Configure here.

@songgaoye songgaoye requested review from a team as code owners January 23, 2026 04:14
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (fb4f703) to head (abf2e28).
⚠️ Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
pebble.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   76.80%   78.41%   +1.60%     
==========================================
  Files          23       23              
  Lines        2048     1700     -348     
==========================================
- Hits         1573     1333     -240     
+ Misses        403      294     -109     
- Partials       72       73       +1     
Files with missing lines Coverage Δ
pebble.go 73.61% <66.66%> (+0.04%) ⬆️

... and 21 files with indirect coverage changes

Files with missing lines Coverage Δ
pebble.go 73.61% <66.66%> (+0.04%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swift1337 swift1337 added this pull request to the merge queue Jan 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 16

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@swift1337 swift1337 added this pull request to the merge queue Jan 27, 2026
Merged via the queue into cometbft:main with commit 3f1d249 Jan 27, 2026
9 of 10 checks passed
@songgaoye songgaoye deleted the fix_pebble_next branch January 27, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants