Skip to content

Comments

test: add unit tests for rocksdb and pebbledb#284

Merged
swift1337 merged 6 commits intocometbft:mainfrom
songgaoye:add_unit_tests
Jan 27, 2026
Merged

test: add unit tests for rocksdb and pebbledb#284
swift1337 merged 6 commits intocometbft:mainfrom
songgaoye:add_unit_tests

Conversation

@songgaoye
Copy link
Contributor

@songgaoye songgaoye commented Jan 23, 2026


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)

Note

Adds focused tests to harden DB backends.

  • Extend backend_test.go to verify range Compact(start,end) works and preserves data, plus pebble-specific cleanup wait
  • New TestPebbleDBNewPebbleDB and TestRocksDBNewRocksDB to assert databases cannot be opened twice for writing
  • Add BenchmarkRocksDBRandomReadsWrites; keep existing Pebble benchmark and backend type assertions

Written by Cursor Bugbot for commit d1d0bfa. This will update automatically on new commits. Configure here.

@songgaoye songgaoye requested review from a team as code owners January 23, 2026 05:22
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.29%. Comparing base (fb4f703) to head (d1d0bfa).
⚠️ Report is 77 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   76.80%   79.29%   +2.48%     
==========================================
  Files          23       23              
  Lines        2048     1700     -348     
==========================================
- Hits         1573     1348     -225     
+ Misses        403      282     -121     
+ Partials       72       70       -2     

see 22 files with indirect coverage changes
see 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swift1337 swift1337 added this pull request to the merge queue Jan 27, 2026
Merged via the queue into cometbft:main with commit f49a671 Jan 27, 2026
10 checks passed
@songgaoye songgaoye deleted the add_unit_tests branch January 27, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants