test: add unit tests for rocksdb and pebbledb#284
Merged
swift1337 merged 6 commits intocometbft:mainfrom Jan 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
swift1337
approved these changes
Jan 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 76.80% 79.29% +2.48%
==========================================
Files 23 23
Lines 2048 1700 -348
==========================================
- Hits 1573 1348 -225
+ Misses 403 282 -121
+ Partials 72 70 -2 see 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
.changelog(we use unclog to manage our changelog)Note
Adds focused tests to harden DB backends.
backend_test.goto verify rangeCompact(start,end)works and preserves data, plus pebble-specific cleanup waitTestPebbleDBNewPebbleDBandTestRocksDBNewRocksDBto assert databases cannot be opened twice for writingBenchmarkRocksDBRandomReadsWrites; keep existing Pebble benchmark and backend type assertionsWritten by Cursor Bugbot for commit d1d0bfa. This will update automatically on new commits. Configure here.