Skip to content

Allow comma service to set niceness #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sshane wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow comma service to set niceness #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
072c990
two methods
sshane Sep 29, 2025
bff15c2
only comma
sshane Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile.agnos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ RUN source $XDG_DATA_HOME/venv/bin/activate && \
export PYOPENCL_CL_PRETEND_VERSION="2.0" && \
MAKEFLAGS="-j$(nproc)" UV_NO_CACHE=1 UV_PROJECT_ENVIRONMENT=$XDG_DATA_HOME/venv uv sync --frozen --inexact --compile-bytecode

## Allow Python to lower nice values (requires CAP_SYS_NICE)
#RUN setcap cap_sys_nice+ep $(readlink -f /usr/local/venv/bin/python)

# Install nice to haves
COPY ./userspace/install_extras.sh /tmp/agnos/
RUN /tmp/agnos/install_extras.sh
Expand Down
1 change: 1 addition & 0 deletions userspace/files/comma.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ After=local-fs.target
Type=oneshot
RemainAfterExit=true
User=comma
AmbientCapabilities=CAP_SYS_NICE
ExecStart=/bin/bash -c "/usr/bin/tmux new-session -s comma -d /usr/comma/comma.sh"
# TODO: send SIGTERM first, then kill after a timeout
ExecStop=/bin/bash -c "/usr/bin/tmux kill-session -t comma"
Expand Down
Loading